KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 1 Projects 1 Releases Wiki Activity

Libc: fix ef_exp.s by Bughunter #177

Merged
mxlgv merged 1 commits from libc-fix into main 2025-04-02 19:34:07 +00:00
Conversation 5 Commits 1 Files Changed 1 +1 -1
IgorA commented 2025-03-21 21:20:39 +00:00
Member
Copy Link
image.png this bug was fixed by Kirilom (by Bughunter) 5 years ago in another similar file
<img width="650" alt="image.png" src="attachments/e2d58257-9103-49fe-ad2a-868a8cb39982"> this bug was fixed by Kirilom (by Bughunter) 5 years ago in another similar file
image.png
43 KiB
IgorA added 1 commit 2025-03-21 21:20:42 +00:00
Libc: fix ef_exp.s by Bughunter
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 28s
Details
Build system / Build (pull_request) Successful in 5m23s
Details
d5c1325b02
dunkaist commented 2025-03-21 21:50:31 +00:00
Owner
Copy Link

menuetlibc: Fix floating exponent calculation

The fix was initially done by Bughunter in 12a6b7f2 (r7958) for double.
This commit applies the same fix to the float exponent.

menuetlibc: Fix floating exponent calculation The fix was initially done by Bughunter in 12a6b7f2 (r7958) for double. This commit applies the same fix to the float exponent.
IgorA commented 2025-03-21 23:27:13 +00:00
Author
Member
Copy Link

The input parameters of the function are in different formats (4 or 8 bytes).
image.png
The algorithm of operation must be the same, because the FPU registers are 80 bits. After exiting the function, the result is converted to 4 or 8 bytes. It is impossible to finally test the correctness of the expf (float) function because the expf function is not exported from the libc library.
image.png

The input parameters of the function are in different formats (4 or 8 bytes). <img width="623" alt="image.png" src="attachments/208e1078-ae3a-4fa1-bb47-7e0c78c8896f"> The algorithm of operation must be the same, because the FPU registers are 80 bits. After exiting the function, the result is converted to 4 or 8 bytes. It is impossible to finally test the correctness of the expf (float) function because the expf function is not exported from the libc library. <img width="125" alt="image.png" src="attachments/c8845d2d-c3ca-4128-864b-d8c141284e4a">
image.png
19 KiB
image.png
2.6 KiB
mxlgv commented 2025-03-22 09:00:17 +00:00
Owner
Copy Link

@IgorA There seems to be no point in this fix since menuetlibc is deprecated.
In libc.obj, the mathematics was taken from here, perhaps there is also a bug there: https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/programs/develop/ktcc/trunk/libc.obj/source/math

@IgorA There seems to be no point in this fix since `menuetlibc` is deprecated. In `libc.obj`, the mathematics was taken from here, perhaps there is also a bug there: https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/programs/develop/ktcc/trunk/libc.obj/source/math
mxlgv added the
PR
Review required
 label 2025-03-22 09:00:52 +00:00
IgorA commented 2025-03-22 12:37:57 +00:00
Author
Member
Copy Link

I made a test program and found that after revision 9842 the exp function was broken.
image.png
image.png
test in excel:
image.png

I made a test program and found that after revision 9842 the exp function was broken. <img width="443" alt="image.png" src="attachments/ebee91c1-0f9c-4f9a-a193-fca5a227a519"> <img width="443" alt="image.png" src="attachments/ec45fc13-5f84-49dc-bed7-65975e9d3f62"> test in excel: <img width="306" alt="image.png" src="attachments/bd85af4d-fb60-4a0e-9fd1-e649b2fe4807">
image.png
9.3 KiB
image.png
13 KiB
image.png
14 KiB
Sweetbread force-pushed libc-fix from d5c1325b02 to 3c547b217f 2025-03-30 14:48:17 +00:00 Compare
mxlgv approved these changes 2025-04-02 18:17:39 +00:00
mxlgv added
PR
Ready to merge
 and removed
PR
Review required
 labels 2025-04-02 18:17:49 +00:00
mxlgv force-pushed libc-fix from 3c547b217f to 2cba153e06 2025-04-02 19:27:23 +00:00 Compare
mxlgv scheduled this pull request to auto merge when all checks succeed 2025-04-02 19:33:29 +00:00
mxlgv merged commit 58cf25fe43 into main 2025-04-02 19:34:07 +00:00
Sweetbread deleted branch libc-fix 2025-04-02 21:52:23 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
PR
Ready to merge
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#177
Delete Branch "libc-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?