KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 2 Projects 1 Releases Wiki Activity

Use 64 bit for times in mpeg4_encode_gop_header() #286

Merged
Burer merged 1 commits from manh-td/kolibrios:mpeg4_encode_gop_header into main 2025-12-20 11:01:46 +00:00
Conversation 4 Commits 1 Files Changed 1 +1 -1
manh-td commented 2025-12-11 12:50:05 +00:00
Contributor
Copy Link

This PR fixes a security vulnerability in mpeg4_encode_gop_header() that was cloned from FFmpeg/FFmpeg but did not receive the security patch.

Vulnerability Details:

  • Affected Function: mpeg4_encode_gop_header() in contrib/sdk/sources/ffmpeg/ffmpeg-2.1/libavcodec/mpeg4videoenc.c
  • Original Fix: 6bbef93883

What this PR does: This PR applies the same security patch that was applied to the original repository to eliminate the vulnerability in the cloned code.

References:

Please review and merge this PR to ensure your repository is protected against this vulnerability.

This PR fixes a security vulnerability in `mpeg4_encode_gop_header()` that was cloned from FFmpeg/FFmpeg but did not receive the security patch. **Vulnerability Details:** * **Affected Function**: `mpeg4_encode_gop_header()` in `contrib/sdk/sources/ffmpeg/ffmpeg-2.1/libavcodec/mpeg4videoenc.c` * **Original Fix**: https://github.com/FFmpeg/FFmpeg/commit/6bbef938839adc55e8e048bc9cc2e0fafe2064df **What this PR does:** This PR applies the same security patch that was applied to the original repository to eliminate the vulnerability in the cloned code. **References:** * https://github.com/FFmpeg/FFmpeg/commit/6bbef938839adc55e8e048bc9cc2e0fafe2064df * https://nvd.nist.gov/vuln/detail/CVE-2018-12458 Please review and merge this PR to ensure your repository is protected against this vulnerability.
manh-td added 1 commit 2025-12-11 12:50:06 +00:00
Use 64 bit for times in mpeg4_encode_gop_header()
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 2m2s
Details
Build system / Build (pull_request) Successful in 40m39s
Details
36c3cbf1b0
Doczom approved these changes 2025-12-14 10:51:10 +00:00
Burer approved these changes 2025-12-19 08:13:39 +00:00
Burer merged commit d0de275ab3 into main 2025-12-20 11:01:46 +00:00
manh-td commented 2025-12-20 12:04:26 +00:00
Author
Contributor
Copy Link

Hi @Burer, thanks for merging our PR. Just want to let you know that we plan to report this as a CVE. Let us know if you have any concerns!

Hi @Burer, thanks for merging our PR. Just want to let you know that we plan to report this as a CVE. Let us know if you have any concerns!
Burer commented 2025-12-20 12:51:18 +00:00
Owner
Copy Link

Hi @Burer, thanks for merging our PR. Just want to let you know that we plan to report this as a CVE. Let us know if you have any concerns!

Hello!

Thank you for your work, but as I can see, you are just transmitting PR's with fixes from ffmpeg upstream.

If so, please, just create one PR with all such fixes, or with full proper port of latest compatible version of ffmpeg.

Otherwise, we would not merge all this PR's one by one.

> Hi @Burer, thanks for merging our PR. Just want to let you know that we plan to report this as a CVE. Let us know if you have any concerns! Hello! Thank you for your work, but as I can see, you are just transmitting PR's with fixes from **ffmpeg** upstream. If so, please, just create one PR with all such fixes, or with full proper port of latest compatible version of **ffmpeg**. Otherwise, we would not merge all this PR's one by one.
Sign in to join this conversation.
Reviewers
No Reviewers
Doczom
Burer
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#286
Delete Branch "manh-td/kolibrios:mpeg4_encode_gop_header"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?