KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 2 Projects 1 Releases Wiki Activity

Remove offset pointer optimization in inftrees.c #292

Closed
Mrcopytuo wants to merge 1 commits from Mrcopytuo/kolibrios:fix-inftrees into main
pull from: Mrcopytuo/kolibrios:fix-inftrees
merge into: KolibriOS:main
Conversation 2 Commits 1 Files Changed 1 +8 -10
Mrcopytuo commented 2025-12-16 06:24:05 +00:00
First-time contributor
Copy Link

Description

This PR applies the same fix as
6a043145ca

The change removes the offset pointer optimization in inftrees.c and replaces it with a C-standard-compliant implementation.

The previous implementation relied on pointer arithmetic that subtracts an offset from a pointer and then indexes from that location. While this worked in practice, it can result in undefined behavior according to the C standard.

Changes

  • Removed offset-based pointer arithmetic in inftrees.c
  • Reworked index calculations to avoid undefined pointer behavior
  • Preserved the original logic and behavior while improving safety and portability

Reference

Upstream commit for comparison:
6a043145ca

## Description This PR applies the same fix as https://github.com/madler/zlib/commit/6a043145ca6e9c55184013841a67b2fef87e44c0 The change removes the offset pointer optimization in `inftrees.c` and replaces it with a C-standard-compliant implementation. The previous implementation relied on pointer arithmetic that subtracts an offset from a pointer and then indexes from that location. While this worked in practice, it can result in undefined behavior according to the C standard. --- ## Changes - Removed offset-based pointer arithmetic in `inftrees.c` - Reworked index calculations to avoid undefined pointer behavior - Preserved the original logic and behavior while improving safety and portability --- ## Reference Upstream commit for comparison: https://github.com/madler/zlib/commit/6a043145ca6e9c55184013841a67b2fef87e44c0
Mrcopytuo added 1 commit 2025-12-16 06:24:06 +00:00
更新 contrib/sdk/sources/zlib/inftrees.c
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 2m4s
Details
Build system / Build (pull_request) Successful in 16m9s
Details
27f411089e
Burer approved these changes 2025-12-21 13:55:54 +00:00
mxlgv commented 2026-01-07 01:35:42 +00:00
Owner
Copy Link

See: #300 (comment)

See: https://git.kolibrios.org/KolibriOS/kolibrios/pulls/300#issuecomment-3798
mxlgv closed this pull request 2026-01-07 01:35:42 +00:00
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 2m4s
Required
Details
Build system / Build (pull_request) Successful in 16m9s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Burer
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#292
Delete Branch "Mrcopytuo/kolibrios:fix-inftrees"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?