KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 2 Projects 1 Releases Wiki Activity

WIP: Shell: improve cpuid - view full brand string #304

Draft
rgimad wants to merge 1 commits from shell-improve-cpuid into main
pull from: shell-improve-cpuid
merge into: KolibriOS:main
Conversation 3 Commits 1 Files Changed 4 +246 -238
rgimad commented 2025-12-31 14:10:33 +00:00
Owner
Copy Link
No description provided.
rgimad added 1 commit 2025-12-31 14:10:34 +00:00
Shell: improve cpuid - view full brand string
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m21s
Details
Build system / Build (pull_request) Successful in 16m21s
Details
bb075099b6
rgimad requested review from Burer 2025-12-31 14:14:40 +00:00
rgimad requested review from dunkaist 2025-12-31 14:15:27 +00:00
mxlgv requested changes 2026-01-02 19:20:17 +00:00
programs/system/shell/shell.c
@@ -1,170 +1,170 @@
mxlgv commented 2026-01-02 19:20:09 +00:00
Owner
Copy Link

You changed either the file encoding or its EOL format.

You changed either the file encoding or its EOL format.
ace-dent commented 2026-01-03 09:26:56 +00:00
Member
Copy Link

The original file had CFRLF eol, and some trailing whitespaces... I'd guess both are fixed automatically in vscode, etc.

@mxlgv - since the only change is whitespace, are you proposing it is excluded from the PR? -Or- a separate Commit for 'white space cleanup' ...?

The original file had `CFRLF` eol, and some trailing whitespaces... I'd guess both are fixed automatically in vscode, etc. @mxlgv - since the only change is whitespace, are you proposing it is excluded from the PR? -Or- a separate Commit for 'white space cleanup' ...?
mxlgv commented 2026-01-07 01:39:57 +00:00
Owner
Copy Link

@ace-dent Hi. I am of the opinion that the fewer changes the better). Spaces may need to be removed, but EOL should be left alone...

It can be changed to “more modern” but not specifically mixed with these changes

@ace-dent Hi. I am of the opinion that the fewer changes the better). Spaces may need to be removed, but EOL should be left alone... It can be changed to “more modern” but not specifically mixed with these changes
Sweetbread reviewed 2026-01-04 20:28:26 +00:00
programs/system/shell/cmd/cmd_kfetch.c
@@ -28,3 +28,2 @@
sprintf(str_resolution, "%u x %u", resol.x + 1, resol.y + 1);
char str_cpu_info[16];
get_str_cpu_info(str_cpu_info);
char str_cpu_info[50];
Sweetbread commented 2026-01-04 20:28:03 +00:00
Owner
Copy Link

Magic number

Magic number
👍 1
programs/system/shell/cmd/cmd_ver.c
@@ -66,0 +49,4 @@
memcpy(out_buffer + (leaf - 0x80000002) * 16, regs, 16);
}
out_buffer[48] = '\0';
Sweetbread commented 2026-01-04 20:27:47 +00:00
Owner
Copy Link

Magic number

Magic number
👍 1
programs/system/shell/cmd/cmd_ver.c
@@ -66,0 +60,4 @@
}
if (!strcmp(param, "cpu")) {
char str[49];
Sweetbread commented 2026-01-04 20:28:17 +00:00
Owner
Copy Link

Magic number

Magic number
👍 1
mxlgv commented 2026-01-28 14:33:13 +00:00
Owner
Copy Link

As I understand it, there are problems with transferring long cpu brand strings.

As I understand it, there are problems with transferring long cpu brand strings.
👍 1
mxlgv changed title from Shell: improve cpuid - view full brand string to WIP: Shell: improve cpuid - view full brand string 2026-01-28 14:33:28 +00:00
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m21s
Required
Details
Build system / Build (pull_request) Successful in 16m21s
Required
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin shell-improve-cpuid:shell-improve-cpuid
git checkout shell-improve-cpuid
Sign in to join this conversation.
Reviewers
No Reviewers
Burer
dunkaist
mxlgv
Sweetbread
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#304
Delete Branch "shell-improve-cpuid"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?