KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 2 Projects 1 Releases Wiki Activity

apps/reshare: rewrite to fasm #305

Open
Burer wants to merge 10 commits from reshare-tweak into main
pull from: reshare-tweak
merge into: KolibriOS:main
Conversation 3 Commits 10 Files Changed 4 +777 -2
Burer commented 2026-01-01 08:40:26 +00:00
Owner
Copy Link

Co-authored-by: @rgimad

What was done:

  • Rewritten to FASM (rgmaid)
  • Refactored code
  • Tweaked UX/UI

What remains to be done:

  • Test, find and fix possible bugs
  • Fit kpack'ed program into 1536 bytes
  • Fit program RAM usage into 1 MB (#make_8mb_great_again)
  • Fit program window with default skin into 800x600
  • Use proper prefixes for debug messages
image.png
Co-authored-by: @rgimad What was done: - [x] Rewritten to FASM (rgmaid) - [x] Refactored code - [x] Tweaked UX/UI What remains to be done: - [x] Test, find and fix possible bugs - [ ] ~~Fit kpack'ed program into 1536 bytes~~ - [x] Fit program RAM usage into 1 MB ([#make_8mb_great_again](https://wiki.kolibrios.org/wiki/SystemRequirements)) - [x] Fit program window with default skin into 800x600 - [x] Use proper prefixes for debug messages <img alt="image.png" src="attachments/ec51c6fc-a274-4b97-8d23-eedcf624133f">
image.png
113 KiB
Burer added the
Kind
Bug
Category/Applications
Priority
Medium
 labels 2026-01-01 08:40:26 +00:00
Burer self-assigned this 2026-01-01 08:40:26 +00:00
Burer added 1 commit 2026-01-01 08:40:26 +00:00
apps/reshare: fix wrong memory tabs names
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m52s
Details
Build system / Build (pull_request) Successful in 16m40s
Details
911faf00ab
Burer requested review from Doczom 2026-01-01 08:40:26 +00:00
Burer requested review from dunkaist 2026-01-01 08:40:26 +00:00
Burer requested review from Sweetbread 2026-01-01 08:40:26 +00:00
mxlgv requested changes 2026-01-12 21:12:28 +00:00
programs/cmm/misc/reshare.c Outdated
@@ -192,3 +192,2 @@
DrawFlatButton( TABX, PAD+30, "ICONS32", 10+ACTIVE_ICONS32, active_tab & ACTIVE_ICONS32);
DrawFlatButton(PAD+BTNW*1+TABX, PAD+30, "ICONS16", 10+ACTIVE_ICONS16, active_tab & ACTIVE_ICONS16);
DrawFlatButton(PAD+BTNW*2+TABX, PAD+30, "ICONS16W", 10+ACTIVE_ICONS16W, active_tab & ACTIVE_ICONS16W);
DrawFlatButton(PAD+BTNW*1+TABX, PAD+30, "ICONS18", 10+ACTIVE_ICONS16, active_tab & ACTIVE_ICONS16);
mxlgv commented 2026-01-12 21:12:24 +00:00
Owner
Copy Link

It seems that ACTIVE_ICONS16 needs to be fixed as well.

It seems that `ACTIVE_ICONS16` needs to be fixed as well.
Burer marked this conversation as resolved
Burer changed title from apps/reshare: fix wrong memory tabs names to WIP: apps/reshare: fix wrong memory tabs names 2026-01-29 09:49:34 +00:00
Burer added 1 commit 2026-02-02 08:24:11 +00:00
apps/reshare: rewrite to fasm
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 37s
Details
Build system / Build (pull_request) Failing after 1m45s
Details
f7b8d753ca 
Co-authored-by: rgimad <rgimad@kolibrios.org>
Burer changed title from WIP: apps/reshare: fix wrong memory tabs names to WIP: apps/reshare: rewrite to fasm 2026-02-02 08:24:32 +00:00
Burer added 1 commit 2026-02-03 10:25:05 +00:00
apps/reshare: rewert broken files rename in data/Tupfile.lua
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 32s
Details
Build system / Build (pull_request) Failing after 2m34s
Details
9093ef3566
Burer added 1 commit 2026-02-03 11:17:47 +00:00
apps/reshare: fix autobuild and code formatting
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 24s
Details
Build system / Build (pull_request) Failing after 2m29s
Details
b75f836a4f
Burer added 1 commit 2026-02-03 11:25:35 +00:00
apps/reshare: fix to previous
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m21s
Details
Build system / Build (pull_request) Successful in 9m45s
Details
916df5a769
Burer added 1 commit 2026-02-05 07:04:12 +00:00
apps/reshare: RAM optimization, code cleanup, prefixes for debug logs
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 38s
Details
Build system / Build (pull_request) Failing after 2m40s
Details
f676109eea
Burer added 1 commit 2026-02-05 07:24:08 +00:00
apps/reshare: fix to previous
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 22s
Details
Build system / Build (pull_request) Failing after 2m28s
Details
084110a2ba
Burer added 1 commit 2026-02-05 08:38:07 +00:00
apps/reshare: fix to previous
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m21s
Details
Build system / Build (pull_request) Successful in 10m17s
Details
7ec23b1400
Burer changed title from WIP: apps/reshare: rewrite to fasm to apps/reshare: rewrite to fasm 2026-02-05 08:49:28 +00:00
mxlgv requested changes 2026-02-11 17:23:47 +00:00
programs/system/reshare/checkbox.inc
@@ -0,0 +1,71 @@
; SPDX-License-Identifier: GPL-2.0-only
;
; Reshare - Shared Resources Daemon
; Copyright (C) 2024 KolibriOS-NG Team
mxlgv commented 2026-02-11 17:17:19 +00:00
Owner
Copy Link

Add copyright KolibriOS 2026

Add copyright KolibriOS 2026
programs/system/reshare/checkbox.inc Outdated
@@ -0,0 +3,4 @@
; Reshare - Shared Resources Daemon
; Copyright (C) 2024 KolibriOS-NG Team
;
; Contributor rgmaid - Main code
mxlgv commented 2026-02-11 17:15:36 +00:00
Owner
Copy Link

just add as a co-author to a pull request or commit

just add as a co-author to a pull request or commit
programs/system/reshare/reshare.asm
@@ -0,0 +1,666 @@
; SPDX-License-Identifier: GPL-2.0-only
;
; Reshare - Shared Resources Daemon
; Copyright (C) 2024-2025 KolibriOS/-NG Team
mxlgv commented 2026-02-11 17:18:26 +00:00
Owner
Copy Link

Although NG was a mistake, it’s not necessary to write through a slash, just add a second copyright after NG

Although NG was a mistake, it’s not necessary to write through a slash, just add a second copyright after NG
programs/system/reshare/reshare.asm Outdated
@@ -0,0 +3,4 @@
; Reshare - Shared Resources Daemon
; Copyright (C) 2024-2025 KolibriOS/-NG Team
;
; Contributor Leency - Original version in C--
mxlgv commented 2026-02-11 17:14:08 +00:00
Owner
Copy Link

Already in the change history

Already in the change history
programs/system/reshare/reshare.asm
@@ -0,0 +4,4 @@
; Copyright (C) 2024-2025 KolibriOS/-NG Team
;
; Contributor Leency - Original version in C--
; Contributor rgmaid - Main code
mxlgv commented 2026-02-11 17:14:42 +00:00
Owner
Copy Link

just add as a co-author to a pull request or commit

just add as a co-author to a pull request or commit
programs/system/reshare/reshare.asm
@@ -0,0 +490,4 @@
ret
.fail:
mxlgv commented 2026-02-11 17:21:13 +00:00
Owner
Copy Link

Maybe it's your style, but I find this arrangement of labels strange

Maybe it's your style, but I find this arrangement of labels strange
programs/system/reshare/reshare.asm
@@ -0,0 +612,4 @@
SHM_CREATE = 0x08
ACTIVE_ICONS32 = 1
ACTIVE_ICONS18 = 2
mxlgv commented 2026-02-11 17:19:30 +00:00
Owner
Copy Link

Why 18 and not 16?

Why 18 and not 16?
Burer commented 2026-02-11 18:58:02 +00:00
Author
Owner
Copy Link

In fact those icons are 18x18 pixels.
So I found it confusing that it in old code "16" was used everywhere and decided to change it.

In fact those icons are 18x18 pixels. So I found it confusing that it in old code "16" was used everywhere and decided to change it.
mxlgv commented 2026-02-27 09:40:58 +00:00
Owner
Copy Link

@Burer Is it possible to rename the file itself to icon18.png or will it break something?

@Burer Is it possible to rename the file itself to `icon18.png` or will it break something?
Burer commented 2026-02-27 16:03:40 +00:00
Author
Owner
Copy Link

It will require renaming it in some other programs that use direct import.
Are we okay with this?

It will require renaming it in some other programs that use direct import. Are we okay with this?
mxlgv commented 2026-03-02 17:56:41 +00:00
Owner
Copy Link

I create a new issue: #349. No changes are required to this PR.

I create a new issue: https://git.kolibrios.org/KolibriOS/kolibrios/issues/349. No changes are required to this PR.
mxlgv marked this conversation as resolved
Burer added 1 commit 2026-03-08 11:09:05 +00:00
apps/reshare: code refactoring, creds cleanup
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 56s
Details
Build system / Build (pull_request) Failing after 2m36s
Details
0380ec1157 
Co-authored-by: @rgimad
Burer added 1 commit 2026-03-08 11:13:19 +00:00
apps/reshare: fix includes
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m13s
Details
Build system / Build (pull_request) Successful in 10m3s
Details
eab5059e00
dunkaist approved these changes 2026-03-08 12:07:02 +00:00
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m13s
Required
Details
Build system / Build (pull_request) Successful in 10m3s
Required
Details
This pull request doesn't have enough required approvals yet. 1 of 2 official approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin reshare-tweak:reshare-tweak
git checkout reshare-tweak
Sign in to join this conversation.
Reviewers
No Reviewers
Doczom
Sweetbread
mxlgv
dunkaist
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Category/Applications
Kind
Bug
Priority
Medium
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees Burer
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#305
Delete Branch "reshare-tweak"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?