KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 2 Projects 1 Releases Wiki Activity

game snake refactoring #331

Open
lexsurkov wants to merge 8 commits from lexsurkov/kolibrios:rewrite-snake into main
pull from: lexsurkov/kolibrios:rewrite-snake
merge into: KolibriOS:main
Conversation 5 Commits 8 Files Changed 10 +767 -878
lexsurkov commented 2026-02-01 14:53:26 +00:00
First-time contributor
Copy Link

#174
Мое предложение по рефакторингу текста в игре snake
Добавлена поддержка русского языка

#174 Мое предложение по рефакторингу текста в игре snake Добавлена поддержка русского языка
lexsurkov added 1 commit 2026-02-01 14:53:27 +00:00
game snake refactoring
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 2m5s
Details
Build system / Build (pull_request) Failing after 2m57s
Details
8e006128c8
lexsurkov added 1 commit 2026-02-02 19:57:17 +00:00
update tupfile
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 50s
Details
Build system / Build (pull_request) Failing after 1m46s
Details
f67c7557e9
lexsurkov added 1 commit 2026-02-02 21:01:26 +00:00
update tupfile
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 30s
Details
Build system / Build (pull_request) Failing after 2m24s
Details
aebe497637
lexsurkov added 1 commit 2026-02-03 07:31:32 +00:00
Merge branch 'main' into rewrite-snake
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 36s
Details
Build system / Build (pull_request) Failing after 1m16s
Details
553a0b3887
lexsurkov added 1 commit 2026-02-03 16:29:45 +00:00
delete include lang
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 52s
Details
Build system / Build (pull_request) Successful in 16m36s
Details
e2174e7a4a
Burer requested changes 2026-02-06 10:56:59 +00:00
Burer left a comment
Owner
Copy Link

Please, use UTF-8 encoding for all files and CP866/CP850 macro for RU/ES locale strings.
Because currently, Cyrillic character display is broken on Gitea.

Here is the example:
https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/programs/develop/charsets/charsets.asm#L1150

image.png
Please, use UTF-8 encoding for all files and CP866/CP850 macro for RU/ES locale strings. Because currently, Cyrillic character display is broken on Gitea. Here is the example: https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/programs/develop/charsets/charsets.asm#L1150 <img alt="image.png" src="attachments/55f85994-87d8-4fa1-a9d5-3aa44877c05b">
image.png
44 KiB
👍 1
mxlgv requested changes 2026-02-11 17:34:41 +00:00
Dismissed
programs/games/snake/functions.asm Outdated
@@ -0,0 +1,144 @@
macro defLabel name, color, [text]
mxlgv commented 2026-02-11 17:32:11 +00:00
Owner
Copy Link

Why in a separate file?

Why in a separate file?
mxlgv marked this conversation as resolved
programs/games/snake/functions.asm Outdated
@@ -0,0 +117,4 @@
; input: squareSideLength - à §¬¥à ï祩ª¨
; -----------------------------
proc draw.setConfigFont squareSideLength
cmp [squareSideLength], MIN_SQUARE_SIDE_LENGTH_FONT
mxlgv commented 2026-02-11 17:34:27 +00:00
Owner
Copy Link

Choose a single style for alignment

Choose a single style for alignment
mxlgv marked this conversation as resolved
lexsurkov added 1 commit 2026-02-16 20:18:37 +00:00
convert utf-8 and refactoring draw buttons
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 43s
Details
Build system / Build (pull_request) Failing after 2m23s
Details
82c9cca556
lexsurkov added 1 commit 2026-02-16 20:23:16 +00:00
remove includes
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 21s
Details
Build system / Build (pull_request) Successful in 16m36s
Details
9ecd89c51b
mxlgv requested changes 2026-02-20 17:29:59 +00:00
Dismissed
mxlgv left a comment
Owner
Copy Link

Please all comments in English

Please all comments in English
mxlgv added the Category/ApplicationsFASM
Kind
Enhancement
Priority
Low
 labels 2026-02-20 17:31:16 +00:00
lexsurkov added 1 commit 2026-02-22 11:06:42 +00:00
translating and fixing comments
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 21s
Details
Build system / Build (pull_request) Failing after 2m23s
Details
f969aec650
lexsurkov force-pushed rewrite-snake from f969aec650 to c092246a99 2026-02-22 11:22:55 +00:00 Compare
lexsurkov requested review from Burer 2026-02-22 11:41:12 +00:00
lexsurkov requested review from mxlgv 2026-02-22 11:41:14 +00:00
mxlgv requested changes 2026-02-23 22:08:08 +00:00
Dismissed
programs/games/snake/functions.asm
@@ -0,0 +123,4 @@
mov ecx, [eax + LABEL.value]
mov esi, [configFont.maskNumber]
or esi, [eax + LABEL.color]
mcall 47, , , , ,[background_color]
mxlgv commented 2026-02-23 22:04:49 +00:00
Owner
Copy Link

Please use constant from KOSfuncs.inc

Please use constant from `KOSfuncs.inc`
programs/games/snake/pause.asm
@@ -18,3 +18,3 @@
call Draw_decorations
call Draw_pause_picture
call Draw_pause_strings
stdcall draw.Navigation, labelMenu, [posLabel.yTop], 0
mxlgv commented 2026-02-23 22:05:38 +00:00
Owner
Copy Link

Bad indentation

Bad indentation
programs/games/snake/snake.asm
@@ -154,2 +145,2 @@
invoke ini.get_color, cur_dir_path, aTheme_name, aEdit_box_selection_color, 0x00aa00
or [edit1.shift_color], eax
; ini navigation color
invoke ini.get_color, cur_dir_path, aTheme_name, configColor.labelNavigation, DEFAULT_NAVIGATION_COLOR
mxlgv commented 2026-02-23 22:06:53 +00:00
Owner
Copy Link

bad indent

bad indent
programs/games/snake/snake.asm
@@ -156,0 +171,4 @@
invoke ini.get_color, cur_dir_path, aTheme_name, configColor.numberLevel, DEFAULT_LABEL_COLOR
mov [numberLevel.color], eax
; ini color game over
invoke ini.get_color, cur_dir_path, aTheme_name, configColor.labelGameOver, DEFAULT_LABEL_END_COLOR
mxlgv commented 2026-02-23 22:07:12 +00:00
Owner
Copy Link

bad indent

bad indent
mxlgv requested changes 2026-02-23 22:13:28 +00:00
mxlgv left a comment
Owner
Copy Link

Please reсheck all the indentations, I see you have a mix of spaces and tabs.

Please reсheck all the indentations, I see you have a mix of spaces and tabs.
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 26s
Required
Details
Build system / Build (pull_request) Successful in 16m14s
Required
Details
This pull request doesn't have enough required approvals yet. 0 of 2 official approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u rewrite-snake:lexsurkov-rewrite-snake
git checkout lexsurkov-rewrite-snake
Sign in to join this conversation.
Reviewers
No Reviewers
Burer
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Category/Applications FASM
Kind
Enhancement
Priority
Low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#331
Delete Branch "lexsurkov/kolibrios:rewrite-snake"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?