KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 2 Projects 1 Releases Wiki Activity

libc.obj: update exit #340

Open
Egor00f wants to merge 5 commits from Egor00f/kolibrios:libc.ob--update-exit into main
pull from: Egor00f/kolibrios:libc.ob--update-exit
merge into: KolibriOS:main
Conversation 2 Commits 5 Files Changed 12 +164 -23
Egor00f commented 2026-02-22 08:36:30 +00:00
Contributor
Copy Link

for auto rebuild crt0.o need #339

from #311

for auto rebuild `crt0.o` need #339 from #311
Egor00f added 1 commit 2026-02-22 08:36:31 +00:00
libc.obj: add call exit after main && translate crt0.asm and convert it to UTF-8
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m16s
Details
Build system / Build (pull_request) Successful in 9m3s
Details
0319a2d7cb
Egor00f added 1 commit 2026-02-22 08:56:27 +00:00
libc.obj: add atexit and normal exit. add exit code save/read
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 20s
Details
Build system / Build (pull_request) Successful in 16m18s
Details
ba8747e2ab
Egor00f added 1 commit 2026-02-22 09:03:20 +00:00
libc.obj: add abort && add exit and _exit to stdlib.h and libc.def
Some checks failed
Build system / Build (pull_request) Failing after 2s
Details
Build system / Check kernel codestyle (pull_request) Successful in 24s
Details
f675fd31b7
Egor00f requested review from mxlgv 2026-02-22 09:03:38 +00:00
Egor00f added 1 commit 2026-02-22 09:07:39 +00:00
libc.obj: add atexit test
Some checks failed
Build system / Build (pull_request) Failing after 2s
Details
Build system / Check kernel codestyle (pull_request) Successful in 23s
Details
275401c06a
mxlgv requested changes 2026-02-23 22:51:23 +00:00
programs/develop/ktcc/trunk/libc.obj/samples/atexit_test.c
@@ -0,0 +1,18 @@
#include <stdlib.h>
mxlgv commented 2026-02-23 22:49:11 +00:00
Owner
Copy Link

Please add copyright:

/*
* SPDX-License-Identifier: GPL-2.0-only
* Copyright (C) 2026 KolibriOS team
*/
Please add copyright: ```c /* * SPDX-License-Identifier: GPL-2.0-only * Copyright (C) 2026 KolibriOS team */ ```
programs/develop/ktcc/trunk/libc.obj/source/crt/crt0.asm Outdated
@@ -56,2 +57,2 @@
jz @f ;загружены кавычки
mov dh, ch ;параметр без кавычек
jz @f ; quotes loaded
mov dh, ch ; parameter without quotes
mxlgv commented 2026-02-23 22:41:02 +00:00
Owner
Copy Link

Please fix indent

Please fix indent
programs/develop/ktcc/trunk/libc.obj/source/stdlib/_exit.c
@@ -0,0 +1,29 @@
#include <conio.h>
mxlgv commented 2026-02-23 22:48:55 +00:00
Owner
Copy Link

Please add copyright:

/*
* SPDX-License-Identifier: GPL-2.0-only
* Copyright (C) 2026 KolibriOS team
*/
Please add copyright: ```c /* * SPDX-License-Identifier: GPL-2.0-only * Copyright (C) 2026 KolibriOS team */ ```
programs/develop/ktcc/trunk/libc.obj/source/stdlib/_exit.h Outdated
@@ -0,0 +1,69 @@
#ifndef __STDLIB_EXIT_H__
mxlgv commented 2026-02-23 22:43:05 +00:00
Owner
Copy Link

It's actually super redundant. I assume that this serves some purpose, but in native code it is unnecessary.

It's actually super redundant. I assume that this serves some purpose, but in native code it is unnecessary.
Egor00f commented 2026-02-25 16:51:21 +00:00
Author
Contributor
Copy Link

I add it for system(). now i thnink will be better add it later.

I add it for `system()`. now i thnink will be better add it later.
mxlgv commented 2026-02-27 09:45:38 +00:00
Owner
Copy Link

I suspect this is redundant. I saw the code for system() in the recent PR. You don't have to wait there for the shell to close; you can call shell exit and it will close immediately.

In fact, in KolibriOS there are no exit codes, what you are trying to do looks like a dirty hack.

I suspect this is redundant. I saw the code for `system()` in the recent PR. You don't have to wait there for the shell to close; you can call `shell exit` and it will close immediately. In fact, in KolibriOS there are no exit codes, what you are trying to do looks like a dirty hack.
Egor00f commented 2026-03-07 16:48:40 +00:00
Author
Contributor
Copy Link

Okay, I'll just delete this. I'll think about it later.

Okay, I'll just delete this. I'll think about it later.
programs/develop/ktcc/trunk/libc.obj/source/stdlib/abort.c Outdated
@@ -0,0 +1,12 @@
#include <stdio.h>
mxlgv commented 2026-02-23 22:48:40 +00:00
Owner
Copy Link

Please add copyright:

/*
* SPDX-License-Identifier: GPL-2.0-only
* Copyright (C) 2026 KolibriOS team
*/
Please add copyright: ```c /* * SPDX-License-Identifier: GPL-2.0-only * Copyright (C) 2026 KolibriOS team */ ```
programs/develop/ktcc/trunk/libc.obj/source/stdlib/atexit.c Outdated
@@ -0,0 +1,35 @@
#include <stdlib.h>
mxlgv commented 2026-02-23 22:48:12 +00:00
Owner
Copy Link

Please add copyright:

/*
* SPDX-License-Identifier: GPL-2.0-only
* Copyright (C) 2026 KolibriOS team
*/
Please add copyright: ```c /* * SPDX-License-Identifier: GPL-2.0-only * Copyright (C) 2026 KolibriOS team */ ```
programs/develop/ktcc/trunk/libc.obj/source/stdlib/exit.c Outdated
@@ -1,12 +1,25 @@
/* Copyright (C) 2021 Logaev Maxim (turbocat2001), GPLv2 */
mxlgv commented 2026-02-23 22:51:04 +00:00
Owner
Copy Link

Please udate copyright:

/*
* SPDX-License-Identifier: GPL-2.0-only
* Copyright (C) 2021 Logaev Maxim
* Copyright (C) 2026 KolibriOS team
*/
Please udate copyright: ```c /* * SPDX-License-Identifier: GPL-2.0-only * Copyright (C) 2021 Logaev Maxim * Copyright (C) 2026 KolibriOS team */ ```
programs/develop/ktcc/trunk/libc.obj/source/stdlib/exit.c
@@ -4,1 +4,4 @@
#include <sys/ksys.h>
#include "_exit.h"
static void __close_all()
mxlgv commented 2026-02-23 22:38:56 +00:00
Owner
Copy Link

TCC does not optimize the codegen. Comment out and write TODO.

TCC does not optimize the codegen. Comment out and write TODO.
mxlgv added a new dependency 2026-02-24 00:02:05 +00:00
#339 libc.obj: add auto build `crt0.o`
Egor00f added 1 commit 2026-03-07 16:52:15 +00:00
libc.obj: add copyright & delete _exit.h & fix tabs in crt0.asm
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 25s
Details
Build system / Build (pull_request) Failing after 1m6s
Details
aa619aa602
Egor00f commented 2026-03-07 17:46:49 +00:00
Author
Contributor
Copy Link

Hmm... maybe it would be better to declare _exit with #define?

Hmm... maybe it would be better to declare `_exit` with `#define`?
Egor00f requested review from mxlgv 2026-03-07 18:52:27 +00:00
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 25s
Required
Details
Build system / Build (pull_request) Failing after 1m6s
Required
Details
This pull request doesn't have enough required approvals yet. 0 of 2 official approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u libc.ob--update-exit:Egor00f-libc.ob--update-exit
git checkout Egor00f-libc.ob--update-exit
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Depends on
#339 libc.obj: add auto build `crt0.o`
KolibriOS/kolibrios
Reference: KolibriOS/kolibrios#340
Delete Branch "Egor00f/kolibrios:libc.ob--update-exit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?