KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 2 Projects 1 Releases Wiki Activity

ftpd: Add mkd command #342

Open
igorsh wants to merge 4 commits from igorsh/kolibrios:ftpd-add-mkd-command into main
pull from: igorsh/kolibrios:ftpd-add-mkd-command
merge into: KolibriOS:main
Conversation 5 Commits 4 Files Changed 2 +106 -2
igorsh commented 2026-02-23 14:13:32 +00:00
Contributor
Copy Link

Added MKD command

Added MKD command
igorsh added 1 commit 2026-02-23 14:13:33 +00:00
ftpd: Add mkd command
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m17s
Details
Build system / Build (pull_request) Successful in 10m27s
Details
ef5b97d0ca
mxlgv requested changes 2026-02-23 21:40:32 +00:00
Dismissed
programs/network/ftpd/commands.inc Outdated
@@ -334,2 +334,4 @@
ret
align 4
console_fs_error:
mxlgv commented 2026-02-23 21:38:35 +00:00
Owner
Copy Link

Don't forget the server in floppy disk image. I think here you can write more optimally, for example, get a line with an error by index.

Don't forget the server in floppy disk image. I think here you can write more optimally, for example, get a line with an error by index.
mxlgv marked this conversation as resolved
programs/network/ftpd/commands.inc
@@ -1251,0 +1322,4 @@
mov byte [edi], 0x00
call create_path
dec edi
mxlgv commented 2026-02-23 21:39:07 +00:00
Owner
Copy Link

Bad ident

Bad ident
mxlgv marked this conversation as resolved
mxlgv added the Category/ApplicationsFASM
Kind
Feature
Priority
Low
PR
Request changes
 labels 2026-02-23 22:16:44 +00:00
igorsh added 2 commits 2026-02-24 17:30:27 +00:00
ftpd: Fix indents c6d82894a0
ftpd: Add function to access filesystem errors by index
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m17s
Details
Build system / Build (pull_request) Successful in 10m0s
Details
2893749afb
mxlgv requested changes 2026-02-25 18:16:13 +00:00
Dismissed
programs/network/ftpd/commands.inc Outdated
@@ -336,0 +337,4 @@
fs_err_table:
dd str_fs_error2 ; 2
dd str_fs_error3 ; 3
dd str_fs_error5 ; 5
mxlgv commented 2026-02-25 18:00:29 +00:00
Owner
Copy Link

I suggest using 4 as str_fs_error

I suggest using 4 as str_fs_error
programs/network/ftpd/commands.inc Outdated
@@ -336,0 +346,4 @@
dd str_fs_error11 ; 11
dd str_fs_error12 ; 12
console_fs_error:
mxlgv commented 2026-02-25 18:08:33 +00:00
Owner
Copy Link

I think you can shorten it something like this

console_fs_error:
        mov edx, 4 ;  Unknown filesystem error
       
        cmp     eax, 2
        jb      .print_err
        cmp     eax, 12
        ja       .print_err
       
        mov edx, eax
        
.print_err:
        sub     edx, 2
        mov     edx, [fs_err_table + edx*4]
        invoke  con_write_asciiz, edx
        ret
I think you can shorten it something like this ```asm console_fs_error: mov edx, 4 ; Unknown filesystem error cmp eax, 2 jb .print_err cmp eax, 12 ja .print_err mov edx, eax .print_err: sub edx, 2 mov edx, [fs_err_table + edx*4] invoke con_write_asciiz, edx ret ```
mxlgv requested changes 2026-02-25 18:29:38 +00:00
Dismissed
programs/network/ftpd/commands.inc
@@ -1251,0 +1323,4 @@
; called fs function
push ebx
dec esp
mov byte[esp], 0
mxlgv commented 2026-02-25 18:27:01 +00:00
Owner
Copy Link

May be xor eax, eax and push eax? I also don’t understand why there is mov and push here. push is smaller in size

May be `xor eax, eax` and `push eax`? I also don’t understand why there is `mov` and `push` here. `push` is smaller in size
igorsh commented 2026-02-28 07:43:59 +00:00
Author
Contributor
Copy Link

Эта часть скопирована с cmdDELE. Если не добавить 1 байт в стек - получаю Page Fault.

Эта часть скопирована с **cmdDELE**. Если не добавить 1 байт в стек - получаю Page Fault.
mxlgv marked this conversation as resolved
mxlgv requested changes 2026-03-02 17:41:28 +00:00
Dismissed
programs/network/ftpd/commands.inc Outdated
@@ -1251,0 +1331,4 @@
push dword SSF_CREATE_FOLDER
mov ebx, esp
mcall SF_FILE
add esp, 6*4 + 1
mxlgv commented 2026-03-02 16:51:06 +00:00
Owner
Copy Link

I guess the problem (https://git.kolibrios.org/KolibriOS/kolibrios/pulls/342/files#issuecomment-4485) is here

I guess the problem (https://git.kolibrios.org/KolibriOS/kolibrios/pulls/342/files#issuecomment-4485) is here
igorsh commented 2026-03-02 18:00:17 +00:00
Author
Contributor
Copy Link

No, at that line - mcall SF_FILE

No, at that line - `mcall SF_FILE`
mxlgv commented 2026-03-02 18:21:09 +00:00
Owner
Copy Link

You are right. I read SF 70 and understood why there is one byte.
But I would still recommend storing 0 in the register and then doing a push and mov.

You are right. I read SF 70 and understood why there is one byte. But I would still recommend storing 0 in the register and then doing a `push` and `mov`.
igorsh commented 2026-03-03 18:00:25 +00:00
Author
Contributor
Copy Link

But I would still recommend storing 0 in the register and then doing a push and mov.

Немного не пойму что ты предлагаешь:
push ebx
xor eax, eax
push eax
add esp, 3

вместо
push ebx
dec esp
mov byte[esp], 0
?

> But I would still recommend storing 0 in the register and then doing a push and mov. Немного не пойму что ты предлагаешь: `push ebx` `xor eax, eax` `push eax` `add esp, 3` вместо `push ebx` `dec esp` `mov byte[esp], 0` ?
mxlgv commented 2026-03-04 02:06:08 +00:00
Owner
Copy Link

I suggest leaving it as is. I'm already confused myself.

I suggest leaving it as is. I'm already confused myself.
mxlgv marked this conversation as resolved
igorsh added 1 commit 2026-03-03 19:04:27 +00:00
ftpd: Simplify console_fs_error logic
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 26s
Details
Build system / Build (pull_request) Successful in 10m19s
Details
e72e908c1a
mxlgv approved these changes 2026-03-07 20:48:54 +00:00
mxlgv removed the
PR
Request changes
 label 2026-03-07 20:49:08 +00:00
mxlgv requested review from Burer 2026-03-07 20:49:14 +00:00
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 26s
Required
Details
Build system / Build (pull_request) Successful in 10m19s
Required
Details
This pull request has changes conflicting with the target branch.
  • programs/network/ftpd/commands.inc
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u ftpd-add-mkd-command:igorsh-ftpd-add-mkd-command
git checkout igorsh-ftpd-add-mkd-command
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
Burer
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Category/Applications FASM
Kind
Feature
Priority
Low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#342
Delete Branch "igorsh/kolibrios:ftpd-add-mkd-command"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?