KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 2 Projects 1 Releases Wiki Activity

heed: Add exit by ESC #345

Open
igorsh wants to merge 3 commits from igorsh/kolibrios:heed-exit-on-esc into main
pull from: igorsh/kolibrios:heed-exit-on-esc
merge into: KolibriOS:main
Conversation 9 Commits 3 Files Changed 1 +5 -4
igorsh commented 2026-02-24 18:11:56 +00:00
Contributor
Copy Link

Added exit on Esc key

Added exit on Esc key
igorsh added 1 commit 2026-02-24 18:11:57 +00:00
heed: Add exit by ESC
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 30s
Details
Build system / Build (pull_request) Successful in 16m38s
Details
815d81f936
Doczom approved these changes 2026-02-28 17:28:33 +00:00
mxlgv requested changes 2026-02-28 19:17:57 +00:00
Dismissed
programs/develop/heed/trunk/heed.asm Outdated
@@ -2701,3 +2701,2 @@
ESC:
btr [flags],8
jmp red
bt [flags], 8
mxlgv commented 2026-02-28 19:17:51 +00:00
Owner
Copy Link

Doesn't btr already store a bit in the CF flag?

Doesn't `btr` already store a bit in the CF flag?
mxlgv marked this conversation as resolved
igorsh added 1 commit 2026-03-01 17:11:50 +00:00
heed: Simplify ESC code
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 23s
Details
Build system / Build (pull_request) Successful in 16m44s
Details
0000458f65
mxlgv requested changes 2026-03-02 17:31:12 +00:00
Dismissed
mxlgv left a comment
Owner
Copy Link

I didn't realize at first that these were changes to the hex editor. I'm not sure that exiting the editor using ESC is necessary (I would like to know your opinion @Doczom @Burer @dunkaist). In addition, the program has a help window and you did not enter information about ESC there. In addition, I think it is necessary to increment the version.

I didn't realize at first that these were changes to the hex editor. I'm not sure that exiting the editor using ESC is necessary (I would like to know your opinion @Doczom @Burer @dunkaist). In addition, the program has a help window and you did not enter information about ESC there. In addition, I think it is necessary to increment the version.
mxlgv added the Category/ApplicationsFASM
Kind
Feature
Priority
Low
 labels 2026-03-02 17:33:44 +00:00
igorsh commented 2026-03-02 18:54:03 +00:00
Author
Contributor
Copy Link

I'm not sure that exiting the editor using ESC is necessary

Heed is the file viewer for KFM. I think it should work just like in Total Commander: F3 to view, Escape to close.

> I'm not sure that exiting the editor using ESC is necessary Heed is the file viewer for KFM. I think it should work just like in Total Commander: F3 to view, Escape to close.
Doczom commented 2026-03-03 11:36:50 +00:00
Owner
Copy Link

Я думаю что данный функционал не будет лишним. Единственное, то необходимо бы добавить проверку на сохранения изменений на момент выхода из приложения.

Я думаю что данный функционал не будет лишним. Единственное, то необходимо бы добавить проверку на сохранения изменений на момент выхода из приложения.
Burer commented 2026-03-03 16:04:41 +00:00
Owner
Copy Link

Is it possible to make it dual-mode?

If you run it from KFM, it should work as Doczom said.

If you run it as a separate program, don't close it with Esc.

Is it possible to make it dual-mode? If you run it from KFM, it should work as Doczom said. If you run it as a separate program, don't close it with Esc.
mxlgv commented 2026-03-04 16:44:05 +00:00
Owner
Copy Link

Я думаю что данный функционал не будет лишним. Единственное, то необходимо бы добавить проверку на сохранения изменений на момент выхода из приложения.

@Doczom I'm not sure that there are any intermediate changes there at all

> Я думаю что данный функционал не будет лишним. Единственное, то необходимо бы добавить проверку на сохранения изменений на момент выхода из приложения. @Doczom I'm not sure that there are any intermediate changes there at all
mxlgv approved these changes 2026-03-07 19:53:31 +00:00
Dismissed
mxlgv added the
PR
Ready to merge
 label 2026-03-07 19:53:43 +00:00
mxlgv removed the
PR
Ready to merge
 label 2026-03-07 20:52:37 +00:00
mxlgv requested changes 2026-03-07 20:53:18 +00:00
mxlgv left a comment
Owner
Copy Link

If you plan to implement this, then you need to fix the help window

If you plan to implement this, then you need to fix the help window
igorsh added 1 commit 2026-03-08 05:03:22 +00:00
heed: Refactor help window (ESC)
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m8s
Details
Build system / Build (pull_request) Successful in 17m50s
Details
9b1de0b705
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m8s
Required
Details
Build system / Build (pull_request) Successful in 17m50s
Required
Details
This pull request doesn't have enough required approvals yet. 0 of 2 official approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u heed-exit-on-esc:igorsh-heed-exit-on-esc
git checkout igorsh-heed-exit-on-esc
Sign in to join this conversation.
Reviewers
No Reviewers
Doczom
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Category/Applications FASM
Kind
Feature
Priority
Low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#345
Delete Branch "igorsh/kolibrios:heed-exit-on-esc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?