KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 2 Projects 1 Releases Wiki Activity

New game #348

Open
Max wants to merge 20 commits from Max/kolibrios:max-patch-1 into main
pull from: Max/kolibrios:max-patch-1
merge into: KolibriOS:main
Conversation 9 Commits 20 Files Changed 3 +1417
Max commented 2026-02-27 16:03:11 +00:00
First-time contributor
Copy Link

Hi, this is a simple solitaire game project.

Hi, this is a simple solitaire game project.
Max added 1 commit 2026-02-27 16:03:12 +00:00
Upload files to "programs/games"
Some checks failed
Build system / Check kernel codestyle (pull_request) Has been cancelled
Details
Build system / Build (pull_request) Has been cancelled
Details
b464de6265
Max changed title from WIP: Upload files to "programs/games" to Upload files to "programs/games" 2026-02-27 16:04:11 +00:00
Max changed title from Upload files to "programs/games" to WIP: Upload files to "programs/games" 2026-02-27 16:04:40 +00:00
Burer commented 2026-02-27 17:48:32 +00:00
Owner
Copy Link

Hi!
Thank you for your PR, but to be merged, it needs some work on:

  1. Write a proper PR description and name.
  2. Write all comments in source code in English.
  3. If you want compiled game to be included in system image, you need to add a Tupfile.
    You can fild examples in this PR:
    https://git.kolibrios.org/KolibriOS/kolibrios/pulls/149/files
Hi! Thank you for your PR, but to be merged, it needs some work on: 1. Write a proper PR description and name. 2. Write all comments in source code in English. 2. If you want compiled game to be included in system image, you need to add a Tupfile. You can fild examples in this PR: https://git.kolibrios.org/KolibriOS/kolibrios/pulls/149/files
Max added 1 commit 2026-02-27 18:19:38 +00:00
Upload files to "programs/games"
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 29s
Details
Build system / Build (pull_request) Failing after 1m36s
Details
593ae0bd7f 
Hi, this is a simple solitaire game project.
Max added 1 commit 2026-02-27 18:39:26 +00:00
Update programs/games/Tupfile.lua
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 21s
Details
Build system / Build (pull_request) Successful in 16m31s
Details
4495fd5981
Burer added 2 commits 2026-02-27 18:51:13 +00:00
apps/solitaires: fix build, translate comments to English 756fa8dd66
Merge branch 'max-patch-1' of https://git.kolibrios.org/Max/kolibrios into max-patch-1
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 23s
Details
Build system / Build (pull_request) Failing after 33s
Details
eb686f3083
Burer added 1 commit 2026-02-27 18:56:50 +00:00
games/solitaries: fix build, part 2
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m28s
Details
Build system / Build (pull_request) Successful in 9m35s
Details
8d55a1cfc8
Burer added 1 commit 2026-02-27 19:08:14 +00:00
games/solitaires: add to image build
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 23s
Details
Build system / Build (pull_request) Successful in 16m30s
Details
79f8b27cfe
Max commented 2026-02-27 19:11:37 +00:00
Author
First-time contributor
Copy Link

Thanks for your help.

Thanks for your help.
❤️ 2
Burer commented 2026-02-27 19:22:14 +00:00
Owner
Copy Link

How input in game works?
I didn't managed to do any action.

How input in game works? I didn't managed to do any action.
Max added 1 commit 2026-02-27 19:23:47 +00:00
Update programs/games/solitare/solitare.asm
Some checks failed
Build system / Build (pull_request) Failing after 5s
Details
Build system / Check kernel codestyle (pull_request) Successful in 28s
Details
7cb981914d
Max commented 2026-02-27 19:28:30 +00:00
Author
First-time contributor
Copy Link

only a mouse, in my case a USB mouse

only a mouse, in my case a USB mouse
Burer commented 2026-02-27 19:32:49 +00:00
Owner
Copy Link

only a mouse, in my case a USB mouse

I tried to use mouse, but nothing happens, no response at all 🤔

Anyway, app is building okay now, but code doesn't really follow best practicies.
I recommend you to fully refactor it using macroses and constants.
You can have good reference here:
#302

> only a mouse, in my case a USB mouse I tried to use mouse, but nothing happens, no response at all 🤔 Anyway, app is building okay now, but code doesn't really follow best practicies. I recommend you to fully refactor it using macroses and constants. You can have good reference here: https://git.kolibrios.org/KolibriOS/kolibrios/pulls/302
Max added 1 commit 2026-02-27 20:09:50 +00:00
Update programs/games/solitare/solitare.asm
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 21s
Details
Build system / Build (pull_request) Successful in 16m19s
Details
932a0fed7d
Max commented 2026-02-27 21:00:13 +00:00
Author
First-time contributor
Copy Link

runs on real hardware

runs on real hardware
SCR_1.PNG
59 KiB
SCR_1.PNG
Max commented 2026-03-01 12:24:24 +00:00
Author
First-time contributor
Copy Link

refactor version

refactor version
solitare.asm
22 KiB
Max added 1 commit 2026-03-01 12:28:32 +00:00
Delete programs/games/solitare/solitare.asm
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 58s
Details
Build system / Build (pull_request) Failing after 1m38s
Details
e2b3ccf541
Max added 1 commit 2026-03-01 12:30:29 +00:00
Upload files to "programs/games/solitare"
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 24s
Details
Build system / Build (pull_request) Successful in 16m21s
Details
848719b5c1 
Refactored version of CARD game
Max added 1 commit 2026-03-01 13:55:05 +00:00
Delete programs/games/solitare/solitare.asm
Some checks failed
Build system / Build (pull_request) Failing after 39s
Details
Build system / Check kernel codestyle (pull_request) Successful in 1m17s
Details
c9484c2f9b
Max added 1 commit 2026-03-01 13:56:54 +00:00
Upload files to "programs/games/solitare"
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 20s
Details
Build system / Build (pull_request) Successful in 16m35s
Details
e1320d573f 
New version, Pixel clipping on edge od screen
Max changed title from WIP: Upload files to "programs/games" to Upload files to "programs/games" 2026-03-01 13:57:58 +00:00
Burer requested changes 2026-03-02 08:50:48 +00:00
Burer left a comment
Owner
Copy Link

Problems:

  • mcall macro can be included from macros.inc, no need to duplicate it in program code
  • Replace all SF and SSF (eax, ebx in mcall) numbers with constants from KOSfuncs.ini
  • Mouse input works only when game window is placed in top-left corner of screen - probably you mismatched screen and window coordinates of mouse

Wishes:

  • Use window type 4 in SF 0 - fixed-size window with skin.
  • Use SF 4 with small font for writing text on cards, and with big font - for score.
Problems: - [ ] mcall macro can be included from macros.inc, no need to duplicate it in program code - [ ] Replace all SF and SSF (eax, ebx in mcall) numbers with constants from KOSfuncs.ini - [ ] Mouse input works only when game window is placed in top-left corner of screen - probably you mismatched screen and window coordinates of mouse Wishes: - [ ] Use window type 4 in SF 0 - fixed-size window with skin. - [ ] Use SF 4 with small font for writing text on cards, and with big font - for score.
👍 2
mxlgv added the Category/ApplicationsFASM
Kind
Feature
Priority
Low
 labels 2026-03-02 18:34:00 +00:00
Max added 1 commit 2026-03-02 19:05:39 +00:00
Delete programs/games/solitare/solitare.asm
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 54s
Details
Build system / Build (pull_request) Failing after 1m40s
Details
5a47b26aeb
Max added 1 commit 2026-03-02 19:06:56 +00:00
Upload files to "programs/games/solitare"
Some checks failed
Build system / Build (pull_request) Failing after 3s
Details
Build system / Check kernel codestyle (pull_request) Successful in 26s
Details
dd15125384 
V1.5 windows mode
Max added 1 commit 2026-03-02 19:11:14 +00:00
Update programs/games/solitare/solitare.asm
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 23s
Details
Build system / Build (pull_request) Successful in 16m51s
Details
836735d28c
Max added 1 commit 2026-03-02 22:02:23 +00:00
Upload files to "programs/games/solitare"
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 27s
Details
Build system / Build (pull_request) Successful in 16m46s
Details
0efc35f8b2 
Add KOSfuncs.inc
Max changed title from Upload files to "programs/games" to New card games 2026-03-03 09:02:26 +00:00
Max changed title from New card games to WIP: New card games 2026-03-03 09:04:48 +00:00
Max commented 2026-03-03 09:09:17 +00:00
Author
First-time contributor
Copy Link

What do you think about this game, will you add it to the system?

What do you think about this game, will you add it to the system?
Max added 1 commit 2026-03-03 11:28:12 +00:00
Upload files to "programs/games/solitare"
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 52s
Details
Build system / Build (pull_request) Successful in 16m52s
Details
5f4b293767 
FIX adding score
Max changed title from WIP: New card games to New card games 2026-03-03 11:32:51 +00:00
Max changed title from New card games to New game 2026-03-03 11:33:49 +00:00
Max requested review from Burer 2026-03-04 09:34:40 +00:00
Max added 1 commit 2026-03-04 17:23:51 +00:00
Upload files to "programs/games/solitare"
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m13s
Details
Build system / Build (pull_request) Successful in 10m44s
Details
8f499f78d5 
Final version of game
Max requested review from mxlgv 2026-03-04 17:37:15 +00:00
Max added 1 commit 2026-03-04 19:04:42 +00:00
Update programs/games/solitare/solitare.asm
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m19s
Details
Build system / Build (pull_request) Successful in 9m33s
Details
88c24062b1
Max removed review request for Burer 2026-03-06 18:15:30 +00:00
Max removed review request for mxlgv 2026-03-06 18:15:45 +00:00
Max requested review from Burer 2026-03-06 18:16:04 +00:00
Max requested review from IgorA 2026-03-06 18:16:35 +00:00
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m19s
Required
Details
Build system / Build (pull_request) Successful in 9m33s
Required
Details
This pull request doesn't have enough required approvals yet. 0 of 2 official approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u max-patch-1:Max-max-patch-1
git checkout Max-max-patch-1
Sign in to join this conversation.
Reviewers
No Reviewers
Burer
IgorA
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Category/Applications FASM
Kind
Feature
Priority
Low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#348
Delete Branch "Max/kolibrios:max-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?