KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 2 Projects 1 Releases Wiki Activity

Добавление в iconv кодировки utf-16le и fix баги #351

Open
lex_coder wants to merge 2 commits from lex_coder/kolibrios:iconv_update_le16 into main
pull from: lex_coder/kolibrios:iconv_update_le16
merge into: KolibriOS:main
Conversation 1 Commits 2 Files Changed 2 +90 -5
lex_coder commented 2026-03-04 13:13:05 +00:00
First-time contributor
Copy Link
  1. Swap from/to - fix bug, iconv_open пакует to в старшие биты, from в младшие. Старый код читал наоборот.
  2. Проверка после RET_TOOFEW, неполная последовательность в конце буфера: выход из цикла вместо ошибки.
1. Swap from/to - fix bug, iconv_open пакует to в старшие биты, from в младшие. Старый код читал наоборот. 2. Проверка после RET_TOOFEW, неполная последовательность в конце буфера: выход из цикла вместо ошибки.
lex_coder added 2 commits 2026-03-04 13:13:06 +00:00
Update iconv UTF-16LE support and fix 04c2b839f3
return fix
Some checks failed
Build system / Check kernel codestyle (pull_request) Has been cancelled
Details
Build system / Build (pull_request) Has been cancelled
Details
0a6f1a7729
lex_coder requested review from Burer 2026-03-04 13:17:45 +00:00
lex_coder requested review from mxlgv 2026-03-04 13:17:50 +00:00
mxlgv requested changes 2026-03-04 16:42:05 +00:00
mxlgv left a comment
Owner
Copy Link

For what purposes are these changes needed? As I remember this ugly library uses WebView. Regarding the inversion of input and output, you need to make sure that this does not break other programs, even if it is a bug.

For what purposes are these changes needed? As I remember this ugly library uses WebView. Regarding the inversion of input and output, you need to make sure that this does not break other programs, even if it is a bug.
Some checks failed
Build system / Check kernel codestyle (pull_request) Has been cancelled
Required
Details
Build system / Build (pull_request) Has been cancelled
Required
Details
This pull request doesn't have enough required approvals yet. 0 of 2 official approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u iconv_update_le16:lex_coder-iconv_update_le16
git checkout lex_coder-iconv_update_le16
Sign in to join this conversation.
Reviewers
No Reviewers
Burer
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#351
Delete Branch "lex_coder/kolibrios:iconv_update_le16"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?