KolibriOS/kolibrios
15
24
Fork 61
Code Issues 132 Pull Requests 32 Actions Projects 1 Releases Wiki Activity

update ksys.h (more functions) #355

Merged
Burer merged 10 commits from Egor00f/kolibrios:update-ksys.h into main 2026-06-08 16:10:38 +00:00
Conversation 13 Commits 10 Files Changed 2
+647 -26
Egor00f commented 2026-03-08 14:35:33 +00:00
Collaborator
Copy Link
Copy Source

added system functions:

  • 18.10
  • 18.13
  • 18.15
  • 18.20
  • 18.22
  • 18.23
  • 18.24
  • 18.25
  • 21.2
  • 21.5
  • 21.11
  • 21.12
  • 22
  • 26.2
  • 26.5
  • 26.11
  • 26.12

add return value for _ksys_kill_by_pid and _ksys_keyboard_layout

and small fixes (grammar fix and extra comma here)

added system functions: + `18.10` + `18.13` + `18.15` + `18.20` + `18.22` + `18.23` + `18.24` + `18.25` + `21.2` + `21.5` + `21.11` + `21.12` + `22` + `26.2` + `26.5` + `26.11` + `26.12` add return value for `_ksys_kill_by_pid` and `_ksys_keyboard_layout` and small fixes ([grammar fix](https://git.kolibrios.org/KolibriOS/kolibrios/commit/e6e4872a4c0199d5264a3b9085fb21c0163740ce) and extra comma [here](https://git.kolibrios.org/KolibriOS/kolibrios/src/commit/9fcf6b705f62c93f224ac32923e18284bfcd67d9/programs/develop/ktcc/trunk/libc.obj/include/sys/ksys.h#L1505))
Egor00f commented 2026-03-08 15:07:52 +00:00
Author
Collaborator
Copy Link
Copy Source

без очепяток никуда

без очепяток никуда
Egor00f force-pushed update-ksys.h from d89aeb2178 to 48fbb1964a 2026-03-10 13:49:38 +00:00 Compare
Egor00f commented 2026-03-10 13:50:50 +00:00
Author
Collaborator
Copy Link
Copy Source

(forced a normal commit title)

(forced a normal commit title)
mxlgv commented 2026-03-11 10:02:58 +00:00
Owner
Copy Link
Copy Source

@Egor00f Why are these changes required?

@Egor00f Why are these changes required?
mxlgv added the CCategory/Libraries
Kind
Enhancement
Priority
Low
Status
Need More Info
 labels 2026-03-11 10:15:12 +00:00
Egor00f commented 2026-03-11 10:15:58 +00:00
Author
Collaborator
Copy Link
Copy Source

@Egor00f Why are these changes required?

  1. I need for peace of mind
  2. I started try to rewrite shell and some syscalls are absent in ksys.h, no need for bicycles in programs
  3. Why not?
  4. Anyway it won't make things worse in any case
> @Egor00f Why are these changes required? 1. I need for peace of mind 2. I started try to rewrite `shell` and some syscalls are absent in `ksys.h`, no need for bicycles in programs 3. Why not? 4. Anyway it won't make things worse in any case
mxlgv requested changes 2026-03-11 11:38:13 +00:00
contrib/sdk/sources/newlib/libc/include/sys/ksys.h Outdated
@@ -787,1 +811,4 @@
/*====== Function 18, subfunction 10 - minimize current window. ========*/
KOSAPI void _ksys_minimize_current_windows()
mxlgv commented 2026-03-11 11:38:10 +00:00
Owner
Copy Link
Copy Source

I recommend using void for functions without a parameter.

I recommend using void for functions without a parameter.
Egor00f commented 2026-03-12 14:13:19 +00:00
Author
Collaborator
Copy Link
Copy Source

umm... it already with void

umm... it already with `void`
mxlgv commented 2026-03-12 21:41:55 +00:00
Owner
Copy Link
Copy Source

I mean: KOSAPI void _ksys_minimize_current_windows(void)

I mean: `KOSAPI void _ksys_minimize_current_windows(void)`
❤️ 1
Egor00f commented 2026-03-13 15:06:36 +00:00
Author
Collaborator
Copy Link
Copy Source

AAAAAAAAAAAAAAAAAA....

AAAAAAAAAAAAAAAAAA....
Egor00f commented 2026-03-15 10:29:15 +00:00
Author
Collaborator
Copy Link
Copy Source

done

done
Egor00f marked this conversation as resolved
mxlgv commented 2026-03-11 11:42:52 +00:00
Owner
Copy Link
Copy Source

@Egor00f Why are these changes required?

  1. I need for peace of mind
  2. I started try to rewrite shell and some syscalls are absent in ksys.h, no need for bicycles in programs
  3. Why not?
  4. Anyway it won't make things worse in any case

There are no other arguments other than SHELL. It won't be any worse... It will be worse when someone uses your wrapper and it turns out not to work because no program uses it to check. In the future, don't add dead code.

> > @Egor00f Why are these changes required? > > 1. I need for peace of mind > 2. I started try to rewrite `shell` and some syscalls are absent in `ksys.h`, no need for bicycles in programs > 3. Why not? > 4. Anyway it won't make things worse in any case There are no other arguments other than SHELL. It won't be any worse... It will be worse when someone uses your wrapper and it turns out not to work because no program uses it to check. In the future, don't add dead code.
mxlgv removed the
Status
Need More Info
 label 2026-03-11 12:23:47 +00:00
Doczom commented 2026-03-22 21:02:55 +00:00
Owner
Copy Link
Copy Source

из всего списка, теоретически необходимыми являются только 18.13, 22, 26.2 и 26.5. Всё остальное уже используется системными программами, либо вообще не должно использоваться не специализированными программами(это про 21.11 и 21.12), либо редко используемо, из-за чего реализация не обязательна в основном подключаемом файле

из всего списка, теоретически необходимыми являются только 18.13, 22, 26.2 и 26.5. Всё остальное уже используется системными программами, либо вообще не должно использоваться не специализированными программами(это про 21.11 и 21.12), либо редко используемо, из-за чего реализация не обязательна в основном подключаемом файле
mxlgv commented 2026-03-23 14:07:09 +00:00
Owner
Copy Link
Copy Source

из всего списка, теоретически необходимыми являются только 18.13, 22, 26.2 и 26.5. Всё остальное уже используется системными программами, либо вообще не должно использоваться не специализированными программами(это про 21.11 и 21.12), либо редко используемо, из-за чего реализация не обязательна в основном подключаемом файле

Я тоже считаю, что ряд врапперов является избыточными, особенно при условии, что они нигде не используются. Но пологаю, что строгих ограничений нет. Думаю это будет слито.

> из всего списка, теоретически необходимыми являются только 18.13, 22, 26.2 и 26.5. Всё остальное уже используется системными программами, либо вообще не должно использоваться не специализированными программами(это про 21.11 и 21.12), либо редко используемо, из-за чего реализация не обязательна в основном подключаемом файле > Я тоже считаю, что ряд врапперов является избыточными, особенно при условии, что они нигде не используются. Но пологаю, что строгих ограничений нет. Думаю это будет слито.
mxlgv requested changes 2026-03-23 14:10:51 +00:00
contrib/sdk/sources/newlib/libc/include/sys/ksys.h Outdated
@@ -859,0 +1018,4 @@
KSYS_KEYBOARD_LAYOUT_ALT = 3
} ksys_keyboard_layout_t;
KOSAPI int _ksys_set_keyboard_layout(ksys_keyboard_layout_t mode, char* table)
mxlgv commented 2026-03-23 14:10:45 +00:00
Owner
Copy Link
Copy Source

const char*?

const char*?
Egor00f commented 2026-05-20 05:05:01 +00:00
Author
Collaborator
Copy Link
Copy Source

done

done
Egor00f marked this conversation as resolved
programs/develop/ktcc/trunk/libc.obj/include/sys/ksys.h Outdated
@@ -833,0 +997,4 @@
asm_inline(
"int $0x40"
: "=a"(err)
: "a"(21), "b"(2), "c"(mode), "d"(table));
mxlgv commented 2026-03-23 14:09:54 +00:00
Owner
Copy Link
Copy Source

const char*?

const char*?
Egor00f commented 2026-03-24 09:37:41 +00:00
Author
Collaborator
Copy Link
Copy Source

maybe...

maybe...
Egor00f commented 2026-05-20 05:04:48 +00:00
Author
Collaborator
Copy Link
Copy Source

done

done
Egor00f marked this conversation as resolved
ace-dent commented 2026-04-20 11:28:12 +00:00
Member
Copy Link
Copy Source

@Egor00f - Please note that the file path for ktcc was recently changed with #425. This will conflict with your changes.

@Egor00f - Please note that the file path for `ktcc` was recently changed with #425. This will conflict with your changes.
Egor00f force-pushed update-ksys.h from d614d248df to 9afd2695ab 2026-05-20 04:54:27 +00:00 Compare
Egor00f changed title from update `ksys.h` to update `ksys.h` (more functions) 2026-05-20 05:05:56 +00:00
Egor00f requested review from mxlgv 2026-05-20 05:06:01 +00:00
dunkaist approved these changes 2026-05-26 22:24:28 +00:00
Egor00f force-pushed update-ksys.h from c749797a0b to 2136f821f8 2026-06-05 13:51:44 +00:00 Compare
Egor00f force-pushed update-ksys.h from 2136f821f8 to 4b73495031 2026-06-06 15:20:44 +00:00 Compare
Egor00f force-pushed update-ksys.h from 4b73495031 to 0e1c18dd2a 2026-06-06 15:23:29 +00:00 Compare
Egor00f added 8 commits 2026-06-06 16:33:48 +00:00
libc.obj: update ksys.h cab93d1c88 
added functions:
+ 18.10
+ 18.13
+ 18.15
+ 18.20
+ 18.22
+ 18.23
+ 18.24
+ 18.25
+ 21.2
+ 21.5
+ 21.11
+ 21.12
+ 22
+ 26.2
+ 26.5
+ 26.11
+ 26.12

fix extra comma in `ksys_draw_bitmap_palette`
mewlib: update ksys.h b7f6f547c1 
added functions:
+ 18.10
+ 18.13
+ 18.15
+ 18.20
+ 18.22
+ 18.23
+ 18.24
+ 18.25
+ 21.2
+ 21.5
+ 21.11
+ 21.12
+ 22
+ 26.2
+ 26.5
+ 26.11
+ 26.12
fix "secondgoes"` 0743c46173
newlib: fix correction of repetitions in ksys.h e434c242dd
libc.obj and newlib: added missed return 530716d2fd 
addув return to `_ksys_keyboard_layout` and replace return value type to `int`, because it can return `-1` [why](91dc4d8cad/kernel/trunk/docs/sysfuncr.txt (L1538))
Added return value for `_ksys_kill_by_pid` [why](91dc4d8cad/kernel/trunk/docs/sysfuncr.txt (L1047))
libc.obj: fix ksys_time_bcd_t 0948432d86
libc.obj&newlib: put void to functions without arguments e7ef6734bd
use const keyboard layout table
Build system / Check kernel codestyle (pull_request) Successful in 47s
Details
Build system / Build (pull_request) Successful in 27m42s
Details
bcd6d5b7b7
Egor00f force-pushed update-ksys.h from 0e1c18dd2a to a5e6062179 2026-06-06 16:33:48 +00:00 Compare
Egor00f force-pushed update-ksys.h from a5e6062179 to bcd6d5b7b7 2026-06-06 16:36:45 +00:00 Compare
Egor00f added 1 commit 2026-06-06 17:10:11 +00:00
fix _ksys_get_kernel_version
Build system / Check kernel codestyle (pull_request) Successful in 37s
Details
Build system / Build (pull_request) Successful in 13m10s
Details
ae90679e98 
in 	#478 `shell` fail because `err` wasn't set
Doczom approved these changes 2026-06-08 09:25:01 +00:00
Burer added 1 commit 2026-06-08 14:32:18 +00:00
libs/ksys.h: fix typos, add missing functions to newlib
Build system / Check kernel codestyle (pull_request) Successful in 25s
Details
Build system / Build (pull_request) Successful in 10m45s
Details
da33dd63c8
Burer force-pushed update-ksys.h from cb78f73c06 to da33dd63c8 2026-06-08 15:56:13 +00:00 Compare
Burer approved these changes 2026-06-08 15:59:33 +00:00
Burer merged commit d08e94331a into main 2026-06-08 16:10:38 +00:00
Burer deleted branch update-ksys.h 2026-06-08 16:10:38 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
dunkaist
Doczom
Burer
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label C Category/Libraries
Kind
Enhancement
Priority
Low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent (Andrew) Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
6 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#355
Delete Branch "Egor00f/kolibrios:update-ksys.h"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?