KolibriOS/kolibrios
15
25
Fork 61
Code Issues 133 Pull Requests 32 Actions Projects 1 Releases Wiki Activity

[GSoC] apps/brainfuck: add Brainfuck interpreter #357

Open
dannydod wants to merge 3 commits from dannydod/kolibrios:brainfuck-interpreter into main
pull from: dannydod/kolibrios:brainfuck-interpreter
merge into: KolibriOS:main
Conversation 9 Commits 3 Files Changed 31
+2800
dannydod commented 2026-03-09 09:15:07 +00:00
First-time contributor
Copy Link
Copy Source

Brainfuck interpreter with interactive REPL interface for KolibriOS.

Features

  • Console-based REPL with interactive commands
  • Use Jump table dispatch for execution
  • RLE preprocessing as optimization
  • Buffered output to minimize redraw
  • File loading support via run <filepath> command
  • REPL commands: help, run, clear, reset, exit
  • Two implementation: bf_shell_interp.asm, bf_console_interp.asm

This is my first contribution to KolibriOS for GSOC 2026
WASM runtime project preparation

Brainfuck interpreter with interactive REPL interface for KolibriOS. ## Features - Console-based REPL with interactive commands - Use Jump table dispatch for execution - RLE preprocessing as optimization - Buffered output to minimize redraw - File loading support via `run <filepath>` command - REPL commands: help, run, clear, reset, exit - Two implementation: bf_shell_interp.asm, bf_console_interp.asm This is my first contribution to KolibriOS for GSOC 2026 WASM runtime project preparation
mxlgv commented 2026-03-11 09:41:46 +00:00
Owner
Copy Link
Copy Source

@dunkaist Do you know if this is part of GSOC, is there a mentor here?

@dunkaist Do you know if this is part of GSOC, is there a mentor here?
dunkaist commented 2026-03-11 11:42:52 +00:00
Owner
Copy Link
Copy Source

@dunkaist Do you know if this is part of GSOC, is there a mentor here?

This is a test task for GSoC, yes. The main project is WASM runtime. I have given feedback in a private conversation to remove the binary and split BF logic into a separate file from bf_*_interp.asm

> @dunkaist Do you know if this is part of GSOC, is there a mentor here? This is a test task for GSoC, yes. The main project is WASM runtime. I have given feedback in a private conversation to remove the binary and split BF logic into a separate file from bf_*_interp.asm
👍 1
mxlgv added GSoC and removed
Status
Need More Info
 labels 2026-03-11 11:46:01 +00:00
mxlgv requested review from Burer 2026-03-14 16:56:58 +00:00
mxlgv requested review from dunkaist 2026-03-14 16:56:59 +00:00
mxlgv requested review from mxlgv 2026-03-14 16:57:00 +00:00
mxlgv commented 2026-03-14 16:57:43 +00:00
Owner
Copy Link
Copy Source

@dannydod
What license is this software distributed under?

@dannydod What license is this software distributed under?
dunkaist reviewed 2026-03-14 18:52:42 +00:00
programs/develop/brainfuck/src/bf_console_interp.asm Outdated
@@ -0,0 +188,4 @@
test eax, eax
jz .display_help
stdcall string.cmp, buffer_data, reset_cmd, 5
dunkaist commented 2026-03-14 18:52:42 +00:00
Owner
Copy Link
Copy Source

This should be 6, I believe. Magic numbers should be avoided. Could you, please, turn this series of stdcall, test, jz to a table of strings and pointers to the corresponding functions? I've seen you used a jump table, therefore pointers to functions shouldn't be a problem for you

This should be 6, I believe. Magic numbers should be avoided. Could you, please, turn this series of stdcall, test, jz to a table of strings and pointers to the corresponding functions? I've seen you used a jump table, therefore pointers to functions shouldn't be a problem for you
dannydod commented 2026-03-15 17:33:43 +00:00
Author
First-time contributor
Copy Link
Copy Source

Hi Ivan, thanks for the review. I would fix refactor the command test, and move all initialized data to after the code.

Hi Ivan, thanks for the review. I would fix refactor the command test, and move all initialized data to after the code.
dunkaist marked this conversation as resolved
dunkaist reviewed 2026-03-14 18:59:29 +00:00
programs/develop/brainfuck/src/bf_shell_interp.asm Outdated
@@ -0,0 +26,4 @@
; data definitions
prompt db "BF:> ", 0
dunkaist commented 2026-03-14 18:59:29 +00:00
Owner
Copy Link
Copy Source

Please, keep code and data separated. You define data both at the start and at the end of the program. In KolibriOS, we usually keep all the data at the end. You can put initialized data after code just before I_END

Please, keep code and data separated. You define data both at the start and at the end of the program. In KolibriOS, we usually keep all the data at the end. You can put initialized data after code just before I_END
dannydod commented 2026-03-15 17:43:21 +00:00
Author
First-time contributor
Copy Link
Copy Source

@mxlgv MIT license. I'll add a LICENSE file in the next commit. Or is there any specific license you would recommend for contributed programs?

@mxlgv MIT license. I'll add a LICENSE file in the next commit. Or is there any specific license you would recommend for contributed programs?
Burer commented 2026-03-16 06:35:49 +00:00
Owner
Copy Link
Copy Source

@mxlgv MIT license. I'll add a LICENSE file in the next commit. Or is there any specific license you would recommend for contributed programs?

If it is port - license of original code should be kept.
If it is written by yourself from scratch - it's totally up to you, but we would recommend GPL-2.0-only, same as KolibriOS kernel code is distributed.

> @mxlgv MIT license. I'll add a LICENSE file in the next commit. Or is there any specific license you would recommend for contributed programs? If it is port - license of original code should be kept. If it is written by yourself from scratch - it's totally up to you, but we would recommend GPL-2.0-only, same as KolibriOS kernel code is distributed.
dannydod added 3 commits 2026-03-19 13:53:40 +00:00
Add Brainfuck Interpreter with interactive REPL 96d2dc11a0 
Console-based REPL Implementation
- Use Jump table dispatch for execution
- RLE preprocessing as optimization
- Buffered output to minimize redraw
- File loading support via run command
- Add REPL commands: help, run, clear, reset, exit
- Two implementation: bf_shell_interp.asm, bf_console_interp.asm

This is my first contribution to KolibriOS for GSOC 2026
 WASM runtime project preparation
Refactor: separate BF logic from interfaces c3d9a2cd4f 
- Extract shared interpreter logic into bf_core.inc
- Console and shell files now only contain interface code
- Use macros (bf_write, bf_getc, write) for interface-specific I/O
- Remove binary file from repository

Addresses Ivan's review feedback from PR #357.
Refactor: change command dispatch to use a table and move data to I_END
Build system / Check kernel codestyle (pull_request) Successful in 40s
Details
Build system / Build (pull_request) Successful in 11m54s
Details
84e83c8926
dannydod force-pushed brainfuck-interpreter from 39ea7b4196 to 84e83c8926 2026-03-19 13:53:40 +00:00 Compare
dunkaist approved these changes 2026-03-23 23:35:57 +00:00
mxlgv requested changes 2026-03-27 01:50:52 +00:00
mxlgv left a comment
Owner
Copy Link
Copy Source

I recommend using the mcall macro and constants from KOSfunc.inc

I recommend using the `mcall` macro and constants from `KOSfunc.inc`
programs/develop/brainfuck/src/bf_shell_interp.asm
@@ -0,0 +1,110 @@
format binary as ""
mxlgv commented 2026-03-27 01:48:20 +00:00
Owner
Copy Link
Copy Source

I recommend adding headers like these to your files:

; SPDX-License-Identifier: GPL-2.0-only 
; Reshare - Shared Resources Daemon
;
; Copyright (C) 2026 KolibriOS Team
I recommend adding headers like these to your files: ```asm ; SPDX-License-Identifier: GPL-2.0-only ; Reshare - Shared Resources Daemon ; ; Copyright (C) 2026 KolibriOS Team ```
programs/develop/brainfuck/src/bf_shell_interp.asm
@@ -0,0 +13,4 @@
dd parameters
dd 00
parameters rb 1024
mxlgv commented 2026-03-27 01:40:40 +00:00
Owner
Copy Link
Copy Source

This increases the size of the binary by a kilobyte

This increases the size of the binary by a kilobyte
programs/develop/brainfuck/src/bf_shell_interp.asm
@@ -0,0 +83,4 @@
int 0x40
I_END:
; data definitions
err1 db "Missing parenthesis match",0
mxlgv commented 2026-03-27 01:49:25 +00:00
Owner
Copy Link
Copy Source

Declaring initialized data after the end of the program image looks wrong

Declaring initialized data after the end of the program image looks wrong
Burer changed title from Add Brainfuck Interpreter to [GSoC] Add Brainfuck Interpreter 2026-04-26 13:30:14 +00:00
Burer changed title from [GSoC] Add Brainfuck Interpreter to [GSoC] apps/brainfuck: add Brainfuck interpreter 2026-06-07 16:57:04 +00:00
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 40s
Required
Details
Build system / Build (pull_request) Successful in 11m54s
Required
Details
Checking for merge conflicts…
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u http://git.kolibrios.org/dannydod/kolibrios brainfuck-interpreter:dannydod-brainfuck-interpreter
git checkout dannydod-brainfuck-interpreter
Sign in to join this conversation.
Reviewers
No Reviewers
Burer
dunkaist
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Category/Applications FASM GSoC
Kind
Feature
Priority
Low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent (Andrew) Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#357
Delete Branch "dannydod/kolibrios:brainfuck-interpreter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?