Hello again, @ramenu! It's been a long time, but finally I am here. And if it is still actual, here are results of testing latest driver version (commit c2ee9ee16d).
- In VirtualBox,…
@Burer, no worries. I knew you were busy, take your time. :)
And I received your email. I'll reply in a short bit, you'll get it from a different email though so check if it goes to spam.
@Burer, you mentioned that it freezes on startup in VMWare right? For some reason, I'm also getting this issue when disabling debug logs on screen. It's weird.
Aha! So it looks like if you pass a page-aligned buffer then PRP2 allocates successfully and no problems occur. However, if a unaligned buffer is used, then it doesn't. So there's a problem with…
Nevermind, there's another nasty bug I found which only happens under certain circumstances, see GSoC/kolibrios-nvme-driver#7.
It seems like this issue always occurs for files between 4KiB and 8Kib. Files below and above that seem to be fine. So it's possible this has to do a bug with allocating a PRP entry for PRP2.
Ok, there's definitely something weird going on. This has happened on more than one occasion. Both on QEMU and Virtualbox, however it's random.
I don't know why exactly this happens, especially…
@sdongles, I found a ugly bug prior to line 1290 which will cause the system to freeze if there's more than one NVMe device registered in the system. I'll add a fix for this later today. Thank you…
You decided to leave the spinlock mechanism. It is not a problem. But can you add some to-do comments about replacing it and why we need to do it later? Also, what problem did you face trying to…
You still have TODO comments. Will they be implemented? Also, I don't think it's worth to add special vim comments
Most of the TODO comments are just future enhancements. The TODO comment…
@ramenu, got it, just want to say, that there is nothing to be sorry about, if you are not active on it. VMWare website for some reason throws server errors when trying to download it for last…
@Burer, I'll try and download VMWare today and see what I can do. :) That being said, were there any other issues you discovered in your testing? Does read/write work okay? No crashes or freezing?…
@Burer, don't get me wrong. I'm still interested in making it work on VMWare. It's just difficult to work on until I install it.
And by automatically updating the image I mean having the…
Also, I'm going to remove the image from the repository as its using quite a bit of storage space and git isn't really suitable for this kind of thing, so I'll edit the Makefile later to…