Kernel: bug in new iso9660 driver #265

New Issue

Doczom · 2025-06-13T18:50:17+02:00

Doczom commented

2025-06-13 18:50:17 +02:00

The names of files and directories obtained by reading the directory do not correspond to the actual file names for the iso9660 without support for the joliet extension

iso image for test

The names of files and directories obtained by reading the directory do not correspond to the actual file names for the iso9660 without support for the joliet extension [iso image for test ](https://t.me/kolibri_os/138116)

Doczom added the

labels 2025-06-13 18:50:17 +02:00

Doczom self-assigned this 2025-06-13 18:50:17 +02:00

Doczom commented

2025-06-13 23:53:37 +02:00

a possible problem has been found. Instead of the movsb instruction, the movsd instruction is used in the following code
It may be worth replacing the jbe instruction with jb

;-----------------------------------------------------------------------------
        ; copy real name
        movzx   ecx, byte[ebx - 1]
        cmp     [ebp + ISO9660.type_encoding], 0
        jnz     .ucs2
        cmp     eax, 2
        je      .ascii2utf16
@@:
        sub     ecx, 1 ; CF + ZF
        jbe     @f
        movsd
        cmp     byte[esi], ';'
        jne     @b
@@:
        mov     byte[edi], 0
        jmp     .end_copy

a possible problem has been found. Instead of the movsb instruction, the movsd instruction is used in the following code It may be worth replacing the jbe instruction with jb ```fasm ;----------------------------------------------------------------------------- ; copy real name movzx ecx, byte[ebx - 1] cmp [ebp + ISO9660.type_encoding], 0 jnz .ucs2 cmp eax, 2 je .ascii2utf16 @@: sub ecx, 1 ; CF + ZF jbe @f movsd cmp byte[esi], ';' jne @b @@: mov byte[edi], 0 jmp .end_copy ```

👍 1

~~Doczom referenced this issue 2025-06-14 20:25:22 +02:00~~

drivers/iso9660: clean code and fix #265 #266

Doczom added a new dependency 2025-06-14 20:29:53 +02:00

#266 drivers/iso9660: clean code and fix #265

Burer referenced a pull request that will close this issue

2025-06-23 12:54:04 +02:00

drivers/iso9660: clean code and fix #265 #266

Sweetbread removed a dependency 2025-06-23 13:28:06 +02:00

#266 drivers/iso9660: clean code and fix #265

Burer closed this issue

2025-06-23 13:30:18 +02:00