KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

drivers/iso9660: clean code and fix #265 #266

Merged
Burer merged 2 commits from fix_iso9660_number_1 into main 2025-06-23 13:30:15 +02:00
Conversation 6 Commits 2 Files Changed 1 +154 -128
Doczom commented 2025-06-14 20:25:21 +02:00
Owner
Copy Link

clean code and fixed bug #265

clean code and fixed bug https://git.kolibrios.org/KolibriOS/kolibrios/issues/265
Doczom added the
FS
Category/Drivers
Category/Kernel
FASM
HardwareTested
 labels 2025-06-14 20:25:21 +02:00
Doczom added 2 commits 2025-06-14 20:25:25 +02:00
Kernel: Fixed magic numbers and constants in iso9660 9664104aa4
Kernel: Fixed bug in iso9660
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m54s
Details
Build system / Build (pull_request) Successful in 11m42s
Details
3fe9c73ffe 
Fixed a bug of outputting erroneous file names in iso9660 (not juliet)
Doczom requested review from dunkaist 2025-06-14 20:25:32 +02:00
Doczom requested review from sdongles 2025-06-14 20:25:33 +02:00
Doczom added a new dependency 2025-06-14 20:29:53 +02:00
#265 Kernel: bug in new iso9660 driver
Burer commented 2025-06-15 08:48:19 +02:00
Owner
Copy Link

Manually tested with Windows 95 Russian ISO image from here, seems to be working okay.

But can you, please, specify where exactly you define CDBlockSize constant?
It is used widely in updated version, but I can't find it's definition anywhere.

Manually tested with Windows 95 Russian ISO image from [here](https://archive.org/details/Win95OSR2RUS), seems to be working okay. But can you, please, specify where exactly you define `CDBlockSize` constant? It is used widely in updated version, but I can't find it's definition anywhere.
image.png
97 KiB
image.png
Doczom commented 2025-06-15 09:56:32 +02:00
Author
Owner
Copy Link

But can you, please, specify where exactly you define CDBlockSize constant?

CDBlockSize defined in blkdev/cd_drv.inc

> But can you, please, specify where exactly you define `CDBlockSize` constant? CDBlockSize defined in [blkdev/cd_drv.inc](https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/kernel/trunk/blkdev/cd_drv.inc#L22)
👍 1
Doczom commented 2025-06-15 10:06:25 +02:00
Author
Owner
Copy Link

You need to use a driver for testing. virt_disk.sys and the virtdisk program .

For example: virtdisk -a "/usbhd0/3/win server 2003.iso"

You need to use a driver for testing. [virt_disk.sys](https://builds.kolibrios.org/ru_RU/data/drivers/disk/virt_disk.sys) and the [virtdisk](https://builds.kolibrios.org/ru_RU/data/programs/system/virtdisk/virtdisk) program . For example: ```virtdisk -a "/usbhd0/3/win server 2003.iso"```
Burer commented 2025-06-15 10:44:30 +02:00
Owner
Copy Link

You need to use a driver for testing. [virt_disk.sys]

Yes, that's exactly what I have done.
Just with another ISO file placed inside kolibrios.iso, and mounted as a separate disk using virtdisk.

> You need to use a driver for testing. [virt_disk.sys] Yes, that's exactly what I have done. Just with another ISO file placed inside `kolibrios.iso`, and mounted as a separate disk using `virtdisk`.
dunkaist approved these changes 2025-06-19 05:06:33 +02:00
Burer approved these changes 2025-06-23 09:17:25 +02:00
Burer changed title from fix_iso9660_number_1 to drivers/iso9660: clean code and fix #265 2025-06-23 12:54:03 +02:00
Burer force-pushed fix_iso9660_number_1 from 3fe9c73ffe to 6aff7b8c02 2025-06-23 12:54:37 +02:00 Compare
Burer removed review request for sdongles 2025-06-23 13:19:01 +02:00
Sweetbread removed a dependency 2025-06-23 13:28:06 +02:00
#265 Kernel: bug in new iso9660 driver
Burer merged commit 6aff7b8c02 into main 2025-06-23 13:30:15 +02:00
Burer deleted branch fix_iso9660_number_1 2025-06-23 13:30:21 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
dunkaist
Burer
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Category/Drivers
Category/Kernel
FASM
FS
HardwareTested
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#266
No description provided.
Delete Branch "fix_iso9660_number_1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?