KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

[Apps/Charsets]: Updated to 0.3.2, added to IMG instead of ASCIIVJU and KEYASCII #113

Merged
mxlgv merged 2 commits from app-charsets-added-to-img into main 2025-03-07 23:59:33 +01:00
Conversation 6 Commits 2 Files Changed 8 +94 -22
Leency commented 2025-03-05 18:51:53 +01:00
Owner
Copy Link
No description provided.
Leency added 1 commit 2025-03-05 18:51:55 +01:00
add CHARSETS app to IMG instead of ASCIIVJU and KEYASCII
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 43s
Details
Build system / Build (pull_request) Failing after 2m44s
Details
d7e16ca0d1
dunkaist commented 2025-03-05 19:07:56 +01:00
Owner
Copy Link

Why do you move ASCIIVJU to outdated? Is it broken? Does it have any bugs? A program doesn't become outdated just because you like another program more.

Why do you move ASCIIVJU to outdated? Is it broken? Does it have any bugs? A program doesn't become outdated just because you like another program more.
👍 1
mxlgv commented 2025-03-06 00:09:03 +01:00
Owner
Copy Link

Please note:

flat assembler version 1.71.57 (16384 kilobytes memory)
asciivju.asm [6]:
include '../../../proc32.inc'
error: file not found.
Please note: ``` flat assembler version 1.71.57 (16384 kilobytes memory) asciivju.asm [6]: include '../../../proc32.inc' error: file not found. ```
mxlgv requested review from mxlgv 2025-03-06 00:09:15 +01:00
mxlgv requested review from dunkaist 2025-03-06 00:09:24 +01:00
mxlgv changed title from add CHARSETS app to IMG instead of ASCIIVJU and KEYASCII to Data: Replace `asciivju` with `charset_checker` in the floppy image. 2025-03-06 00:13:40 +01:00
mxlgv reviewed 2025-03-06 00:16:03 +01:00
data/Tupfile.lua Outdated
@@ -471,4 +471,3 @@
{"DEVELOP/FASM", VAR_PROGS .. "/develop/fasm/1.73/fasm"},
{"DEVELOP/H2D2B", VAR_PROGS .. "/develop/h2d2b/trunk/h2d2b"},
{"DEVELOP/HEED", VAR_PROGS .. "/develop/heed/trunk/heed"},
{"DEVELOP/KEYASCII", VAR_PROGS .. "/develop/keyascii/trunk/keyascii"},
mxlgv commented 2025-03-06 00:15:08 +01:00
Owner
Copy Link

Please justify the removal

Please justify the removal
Burer commented 2025-03-07 09:16:34 +01:00
Owner
Copy Link

Charsets have all functionality of keyascii and asciivju, plus support of Unicode.
No reason to duplicate functionality in .IMG.
Can be moved to ISO, I suppose.

Charsets have all functionality of keyascii and asciivju, plus support of Unicode. No reason to duplicate functionality in .IMG. Can be moved to ISO, I suppose.
👍 1
mxlgv changed title from Data: Replace `asciivju` with `charset_checker` in the floppy image. to Replace `asciivju` with `charset_checker` in the floppy image. 2025-03-06 00:17:17 +01:00
Burer added 1 commit 2025-03-07 09:01:41 +01:00
Charsets Checker 0.3.2
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 49s
Details
Build system / Build (pull_request) Failing after 2m16s
Details
a930f8fd8f 
- Renamed to Charsets Viewer/Charsets
- Fixed rolled-up bug
- Tweaked UI a little bit
- Renamed files in autobuild
mxlgv requested changes 2025-03-07 11:19:44 +01:00
Dismissed
programs/other/charsets/charsets.asm Outdated
@@ -0,0 +38,4 @@
call draw_window ; We call the window_draw function and
jmp event_wait ; jump back to event_wait
key: ; Keypress event handler
mxlgv commented 2025-03-07 11:19:12 +01:00
Owner
Copy Link

Let's probably add KolibriOS copyright:

; SPDX-License-Identifier: GPL-2.0-only
; SPDX-FileCopyrightText: 2024-2025 KolibriOS Team
Let's probably add KolibriOS copyright: ```asm ; SPDX-License-Identifier: GPL-2.0-only ; SPDX-FileCopyrightText: 2024-2025 KolibriOS Team ```
programs/other/charsets/charsets.asm Outdated
@@ -0,0 +183,4 @@
; Don't draw rolled up or rolled down window
mcall 9, proc_info, -1
mov eax, [proc_info + 70]
mxlgv commented 2025-03-07 11:03:36 +01:00
Owner
Copy Link

Perhaps tabs instead of spaces. Fix it.

There are more similar errors further down in the file.

Perhaps tabs instead of spaces. Fix it. There are more similar errors further down in the file.
programs/other/charsets/charsets.asm Outdated
@@ -0,0 +659,4 @@
MEM:
; Development history
mxlgv commented 2025-03-07 11:07:46 +01:00
Owner
Copy Link

I think it’s better to put it in a separate file, for example ChangeLog.

Or place it on top.

I think it’s better to put it in a separate file, for example ChangeLog. Or place it on top.
mxlgv commented 2025-03-07 11:26:57 +01:00
Owner
Copy Link

@Leency @Burer

Return asciivju to the old directory yourself and correct the commit message. Or ask the maintainer do this.

@Leency @Burer Return `asciivju` to the old directory yourself and correct the commit message. Or ask the maintainer do this.
Burer added 1 commit 2025-03-07 13:32:54 +01:00
Structure tweaks and codestyle fixes
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 30s
Details
Build system / Build (pull_request) Successful in 8m51s
Details
f687b4d1ad 
- Moved charsets to programs/develop
- Moved asciivju back to programs/develop
- Replaced tabs with spaced in charsets.asm
- Added credits in charsets.asm
- Moved charsets dev history to separate file
Burer changed title from Replace `asciivju` with `charset_checker` in the floppy image. to [Apps/Charsets]: Updated to 0.3.2, added to IMG instead of ASCIIVJU and KEYASCII 2025-03-07 13:34:04 +01:00
Burer force-pushed app-charsets-added-to-img from f687b4d1ad to 79ce4cf896 2025-03-07 13:35:00 +01:00 Compare
mxlgv force-pushed app-charsets-added-to-img from 79ce4cf896 to 77d26709b0 2025-03-07 23:24:49 +01:00 Compare
mxlgv force-pushed app-charsets-added-to-img from 77d26709b0 to bf587ffa60 2025-03-07 23:30:02 +01:00 Compare
mxlgv approved these changes 2025-03-07 23:59:16 +01:00
mxlgv merged commit 19d192dc38 into main 2025-03-07 23:59:33 +01:00
mxlgv deleted branch app-charsets-added-to-img 2025-03-07 23:59:36 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
dunkaist
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#113
No description provided.
Delete Branch "app-charsets-added-to-img"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?