KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

Unvwater demo: Improved code style and added support for window resizing #141

Merged
mxlgv merged 2 commits from update-unvwater into main 2025-03-14 23:06:00 +01:00
Conversation 6 Commits 2 Files Changed 5 +235 -335
IgorA commented 2025-03-13 10:52:28 +01:00
Member
Copy Link

Apps/unwather:

  • Improved code style and readability
  • Added support for window resizing
Apps/unwather: - Improved code style and readability - Added support for window resizing
IgorA added 2 commits 2025-03-13 10:52:31 +01:00
Apps/unvwater: Improved code style and readability eaf0e3c030
Apps/unvwater: Added support for window resizing
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 30s
Details
Build system / Build (pull_request) Successful in 4m49s
Details
542cb9e8b8
mxlgv requested changes 2025-03-14 20:32:07 +01:00
Dismissed
mxlgv changed title from update-unvwater to Unvwater demo: Improved code style and added support for window resizing 2025-03-14 20:33:25 +01:00
mxlgv added the
Category/General
 label 2025-03-14 20:33:53 +01:00
mxlgv added
Category/Applications
Kind
Enhancement
Priority
Low
 and removed
Category/General
 labels 2025-03-14 20:35:23 +01:00
mxlgv requested review from mxlgv 2025-03-14 20:52:36 +01:00
mxlgv approved these changes 2025-03-14 20:52:58 +01:00
Dismissed
dunkaist reviewed 2025-03-14 20:54:52 +01:00
programs/demos/unvwater/unvwater.asm Outdated
@@ -0,0 +1,230 @@
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
dunkaist commented 2025-03-14 20:54:52 +01:00
Owner
Copy Link

Our unvwater is a rewrite from OctASM, part os OctaOS, an experimental OS by Octavio Vega. Since it's a complete rewrite, the license can be our default one, i.e. GPL-2.0-only. That said, I think it's a proper thing to mention the original author too.

Our unvwater is a [rewrite](https://board.kolibrios.org/viewtopic.php?p=56520#p56520) from OctASM, part os [OctaOS](https://board.flatassembler.net/topic.php?t=3316), an experimental OS by Octavio Vega. Since it's a complete rewrite, the license can be our default one, i.e. GPL-2.0-only. That said, I think it's a proper thing to mention the original author too.
mxlgv commented 2025-03-14 21:00:10 +01:00
Owner
Copy Link

Thanks for explaining then I think it's still worth adding copyright!

Thanks for explaining then I think it's still worth adding copyright!
👍 1
mxlgv marked this conversation as resolved
mxlgv force-pushed update-unvwater from 542cb9e8b8 to 26213e0cd4 2025-03-14 20:55:01 +01:00 Compare
mxlgv requested review from mxlgv 2025-03-14 21:00:15 +01:00
mxlgv requested changes 2025-03-14 21:03:50 +01:00
Dismissed
mxlgv left a comment
Owner
Copy Link

Please add copyright:

; SPDX-License-Identifier: GPL-2.0
; Unvwater demo
; Copyright (C) 2010-2025 KolibriOS team

And keep the original comments.

Please add copyright: ``` ; SPDX-License-Identifier: GPL-2.0 ; Unvwater demo ; Copyright (C) 2010-2025 KolibriOS team ``` And keep the original comments.
IgorA added 1 commit 2025-03-14 22:21:50 +01:00
Apps/unvwather: fix license
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 30s
Details
Build system / Build (pull_request) Successful in 7m35s
Details
af080312c0
mxlgv approved these changes 2025-03-14 22:40:03 +01:00
Dismissed
mxlgv force-pushed update-unvwater from af080312c0 to 8502a94cf0 2025-03-14 22:42:01 +01:00 Compare
mxlgv dismissed mxlgv’s review 2025-03-14 22:42:01 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

mxlgv requested review from mxlgv 2025-03-14 22:46:01 +01:00
mxlgv approved these changes 2025-03-14 22:46:05 +01:00
mxlgv force-pushed update-unvwater from 8502a94cf0 to 31ca1c76bb 2025-03-14 22:58:28 +01:00 Compare
mxlgv merged commit 31ca1c76bb into main 2025-03-14 23:06:00 +01:00
mxlgv deleted branch update-unvwater 2025-03-14 23:06:01 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Category/Applications
Kind
Enhancement
Priority
Low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#141
No description provided.
Delete Branch "update-unvwater"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?