KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

programs/shell: Show new fields of sf18.13 struct #148

Closed
dunkaist wants to merge 0 commits from dunkaist/kolibrios:pr-update-shell-for-git into main
pull from: dunkaist/kolibrios:pr-update-shell-for-git
merge into: KolibriOS:main
Conversation 4 Commits - Files Changed -
dunkaist commented 2025-03-15 03:17:33 +01:00
Owner
Copy Link

In short, report a git hash etc instead of an svn revision.

In short, report a git hash etc instead of an svn revision.
dunkaist added 1 commit 2025-03-15 03:17:35 +01:00
programs/shell: Show new fields of sf18.13 struct
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 29s
Details
Build system / Build (pull_request) Successful in 5m22s
Details
201ab9dfdc 
In short, report a git hash etc instead of an svn revision.
mxlgv requested changes 2025-03-15 22:03:31 +01:00
Dismissed
mxlgv left a comment
Owner
Copy Link

If I understand correctly this change requires this: #146. Will be approved after merge.

If I understand correctly this change requires this: https://git.kolibrios.org/KolibriOS/kolibrios/pulls/146. Will be approved after merge.
👍 1
mxlgv added the
PR
Dependent
 label 2025-03-15 22:07:44 +01:00
mxlgv added the
Priority
High
 label 2025-03-15 22:16:21 +01:00
mxlgv added a new dependency 2025-03-15 22:16:48 +01:00
#146 kernel: Clean up svn-related code and data
Sweetbread force-pushed pr-update-shell-for-git from 201ab9dfdc to 44117c131e 2025-03-17 20:18:56 +01:00 Compare
Sweetbread added
PR
Review required
 and removed
PR
Dependent
 labels 2025-03-17 20:19:52 +01:00
Sweetbread requested review from mxlgv 2025-03-17 20:19:52 +01:00
Sweetbread added the
Category/Kernel
Kind
Enhancement
 labels 2025-03-17 20:20:37 +01:00
mxlgv requested changes 2025-03-17 22:38:05 +01:00
Dismissed
programs/system/shell/cmd/cmd_kfetch.c Outdated
@@ -11,0 +10,4 @@
struct kernel_version kv;
int eol;
kol_get_kernel_ver(&kv);
char *str_os_rel_offset_dbgtag = malloc(24);
mxlgv commented 2025-03-17 22:38:02 +01:00
Owner
Copy Link

Please do not repeat the mistake of the previous developer. If possible, allocate it on the stack. The malloc() from libc.obj is just a wrapper for syscall. This will result in a page allocation (4К) instead of 64 bytes!

Please do not repeat the mistake of the previous developer. If possible, allocate it on the stack. The `malloc()` from `libc.obj` is just a wrapper for syscall. This will result in a page allocation (4К) instead of 64 bytes!
👍 1
mxlgv added
PR
Request changes
 and removed
PR
Review required
 labels 2025-03-17 22:39:44 +01:00
dunkaist force-pushed pr-update-shell-for-git from 44117c131e to e62e3f7526 2025-03-17 22:54:19 +01:00 Compare
dunkaist force-pushed pr-update-shell-for-git from e62e3f7526 to 6b80899bcf 2025-03-17 23:05:42 +01:00 Compare
mxlgv approved these changes 2025-03-17 23:22:24 +01:00
mxlgv added
PR
Ready to merge
 and removed
PR
Request changes
 labels 2025-03-17 23:22:39 +01:00
mxlgv force-pushed pr-update-shell-for-git from 6b80899bcf to 32466e31f4 2025-03-17 23:22:57 +01:00 Compare
mxlgv scheduled this pull request to auto merge when all checks succeed 2025-03-17 23:24:26 +01:00
mxlgv commented 2025-03-17 23:44:51 +01:00
Owner
Copy Link

Merged: 32466e31f4

Merged: https://git.kolibrios.org/KolibriOS/kolibrios/commit/32466e31f4ae86b92b1c3539b9ce4bd3090d9bcd
mxlgv closed this pull request 2025-03-17 23:44:57 +01:00
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 41s
Required
Details
Build system / Build (pull_request) Successful in 6m3s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Category/Kernel
Kind
Enhancement
Priority
High
PR
Ready to merge
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Depends on
#146 kernel: Clean up svn-related code and data
KolibriOS/kolibrios
Reference: KolibriOS/kolibrios#148
No description provided.
Delete Branch "dunkaist/kolibrios:pr-update-shell-for-git"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?