KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

[Apps/Pipet] Rewrite from C-- to FASM, add new functionality #149

Merged
mxlgv merged 1 commits from pipet-rewrite-to-fasm into main 2025-03-16 12:29:11 +01:00
Conversation 6 Commits 1 Files Changed 3 +552 -1
Leency commented 2025-03-15 13:58:50 +01:00
Owner
Copy Link
  • Function to select not a single pixel, but a 7*7 rect from screen
  • Function to select each pixel from selected rect
  • Updated UX/UI
- Function to select not a single pixel, but a 7*7 rect from screen - Function to select each pixel from selected rect - Updated UX/UI
Leency added 2 commits 2025-03-15 13:58:54 +01:00
[Apps/Pipet] Rewritten to FASM f3eb2fd3ce
[Apps/Pipet] Updated to 2.0
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 39s
Details
Build system / Build (pull_request) Successful in 5m50s
Details
fa514e2111 
- Function to select not a single pixel, but a 7*7 rect from screen
- Function to select each pixel from selected rect
- Updated UX/UI
Leency added 1 commit 2025-03-15 14:38:25 +01:00
asm pipet: add to IMG replacing cmm pipet, use cp866 lang for src
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 30s
Details
Build system / Build (pull_request) Failing after 36s
Details
f6f925e49d
Leency changed title from WiP: pipet-rewrite-to-fasm to pipet-rewrite-to-fasm 2025-03-15 14:39:10 +01:00
Leency added 1 commit 2025-03-15 14:44:59 +01:00
fix prior
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 28s
Details
Build system / Build (pull_request) Failing after 34s
Details
8cac6b09dd
Leency added 1 commit 2025-03-15 14:50:54 +01:00
fix path
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 27s
Details
Build system / Build (pull_request) Successful in 5m48s
Details
da43ae6ac3
mxlgv requested changes 2025-03-15 21:30:33 +01:00
Dismissed
programs/other/pipet/pipet.asm Outdated
@@ -0,0 +1,538 @@
use32
mxlgv commented 2025-03-15 21:26:57 +01:00
Owner
Copy Link

This is a new program, add copyright KolibriOS!

This is a new program, add copyright KolibriOS!
Burer marked this conversation as resolved
programs/other/pipet/pipet.asm Outdated
@@ -0,0 +420,4 @@
; picking one color cell from 7*7 grid
pick_col_cell:
mcall 37, 1
mxlgv commented 2025-03-15 21:28:28 +01:00
Owner
Copy Link

Please replace this with costants from KOSfuncs.inc. And for everyone mcall.

Please replace this with costants from `KOSfuncs.inc`. And for everyone `mcall`.
Burer marked this conversation as resolved
mxlgv commented 2025-03-15 21:31:04 +01:00
Owner
Copy Link

Is this WIP? Or is it already ready?

Is this WIP? Or is it already ready?
mxlgv changed title from pipet-rewrite-to-fasm to Pipet rewrite to fasm 2025-03-15 21:31:55 +01:00
mxlgv added the
PR
Request changes
 label 2025-03-15 22:00:07 +01:00
Burer added 3 commits 2025-03-16 09:15:59 +01:00
[Apps/Pipet] Added credits. Refactored all mcall's to use KOSfuncs.inc f5bd78c8a1
Merge branch 'pipet-rewrite-to-fasm' of ssh://kolibrios.org:222/KolibriOS/kolibrios into pipet-rewrite-to-fasm 8f07bc58ec
Fixed encoding to CP866
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 31s
Details
Build system / Build (pull_request) Successful in 5m19s
Details
175c765505
Burer commented 2025-03-16 09:22:51 +01:00
Owner
Copy Link

Is this WIP? Or is it already ready?

It is already ready.
Your comments have been taken into account and fixed.

> Is this WIP? Or is it already ready? It is already ready. Your comments have been taken into account and fixed.
Burer added
PR
Review required
 and removed
PR
Request changes
 labels 2025-03-16 09:57:10 +01:00
Burer changed title from Pipet rewrite to fasm to [Apps/Pipet] Rewrite from C-- to FASM, added new functionality 2025-03-16 10:29:08 +01:00
Burer changed title from [Apps/Pipet] Rewrite from C-- to FASM, added new functionality to [Apps/Pipet] Rewrite from C-- to FASM, add new functionality 2025-03-16 10:29:21 +01:00
mxlgv requested changes 2025-03-16 10:30:05 +01:00
Dismissed
programs/other/pipet/pipet.asm Outdated
@@ -0,0 +1,547 @@
; SPDX-License-Identifier: GPL-2.0-only
; SPDX-FileCopyrightText: 2004-2025 KolibriOS Team
mxlgv commented 2025-03-16 10:30:02 +01:00
Owner
Copy Link

This is a new program, there should only be 2025

This is a new program, there should only be 2025
Burer marked this conversation as resolved
mxlgv added
PR
Request changes
 and removed
PR
Review required
 labels 2025-03-16 10:30:42 +01:00
Burer added 1 commit 2025-03-16 10:31:10 +01:00
[Apps/Pipet] Fixed dates in credits
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 28s
Details
Build system / Build (pull_request) Successful in 5m21s
Details
79cf625a7d
mxlgv approved these changes 2025-03-16 10:39:57 +01:00
Dismissed
mxlgv added
PR
Ready to merge
 and removed
PR
Request changes
 labels 2025-03-16 10:40:13 +01:00
mxlgv force-pushed pipet-rewrite-to-fasm from 79cf625a7d to e0413cd421 2025-03-16 12:03:16 +01:00 Compare
mxlgv dismissed mxlgv’s review 2025-03-16 12:03:17 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

mxlgv force-pushed pipet-rewrite-to-fasm from e0413cd421 to 02711ca9a8 2025-03-16 12:08:53 +01:00 Compare
Burer force-pushed pipet-rewrite-to-fasm from 02711ca9a8 to e353771faa 2025-03-16 12:18:47 +01:00 Compare
mxlgv requested review from mxlgv 2025-03-16 12:28:47 +01:00
mxlgv approved these changes 2025-03-16 12:28:58 +01:00
mxlgv merged commit e353771faa into main 2025-03-16 12:29:11 +01:00
mxlgv deleted branch pipet-rewrite-to-fasm 2025-03-16 12:29:11 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
PR
Ready to merge
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#149
No description provided.
Delete Branch "pipet-rewrite-to-fasm"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?