KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

Movback: Added support window resizing #160

Merged
mxlgv merged 2 commits from update-movback into main 2025-03-17 23:08:03 +01:00
Conversation 6 Commits 2 Files Changed 6 +91 -48
IgorA commented 2025-03-16 23:46:26 +01:00
Member
Copy Link

Movback: Deleted trunk dir. Added support window resizing.

Movback: Deleted trunk dir. Added support window resizing.
IgorA added 2 commits 2025-03-16 23:46:29 +01:00
Movback: Deleted trunk dir. Files moved 1869449309
Movback: Added support window resizing
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m9s
Details
Build system / Build (pull_request) Successful in 7m38s
Details
5a907e131b
dunkaist reviewed 2025-03-17 00:55:15 +01:00
programs/demos/movback/movback.asm Outdated
@@ -0,0 +17,4 @@
CODE
mcall SF_SYS_MISC,SSF_HEAP_INIT
dunkaist commented 2025-03-17 00:55:15 +01:00
Owner
Copy Link

This file uses spaces for indentation. You added tabs. Mixing tabs and spaces in one file is bad. Please, keep the indentation style used in the file, i.e. spaces. Thank you.

This file uses spaces for indentation. You added tabs. Mixing tabs and spaces in one file is bad. Please, keep the indentation style used in the file, i.e. spaces. Thank you.
IgorA commented 2025-03-17 18:42:49 +01:00
Author
Member
Copy Link

add tabs

add tabs
dunkaist commented 2025-03-17 19:21:33 +01:00
Owner
Copy Link

I see two issues here

  1. Your patch changes the whole file now, which is not necessary.
  2. You converted the existing indent style to what you like with no reason. What if the next developer prefers spaces over tabs, should they replace all the tabs with spaces again? The rule of thumb is as follows: if you are the main developer of a program or a maintainer, use the style you like; if you are an occasional contributor to the program, follow the existing style.

Having said that, if @mxlgv is ok with this change, I am ok too.

I see two issues here 1. Your patch changes the whole file now, which is not necessary. 2. You converted the existing indent style to what you like with no reason. What if the next developer prefers spaces over tabs, should they replace all the tabs with spaces again? The rule of thumb is as follows: if you are the main developer of a program or a maintainer, use the style you like; if you are an occasional contributor to the program, follow the existing style. Having said that, if @mxlgv is ok with this change, I am ok too.
mxlgv commented 2025-03-17 20:16:03 +01:00
Owner
Copy Link

I think @dunkaist is right. The fewer visual changes the better if it does not concern functionality. But unfortunately we do not have requirements for the style of the source code (

I think @dunkaist is right. The fewer visual changes the better if it does not concern functionality. But unfortunately we do not have requirements for the style of the source code (
dunkaist reviewed 2025-03-17 01:03:58 +01:00
programs/demos/movback/movback.asm Outdated
dunkaist commented 2025-03-17 01:03:58 +01:00
Owner
Copy Link

You removed this include directive, but the file 'lang.inc' is still generated in Tupfile.lua. Please, change the two last lines in Tupfile.lua with the following one:
tup.rule("movback.asm", FASM .. " %f %o " .. tup.getconfig("KPACK_CMD"), "movback")

You removed this include directive, but the file 'lang.inc' is still generated in Tupfile.lua. Please, change the two last lines in Tupfile.lua with the following one: `tup.rule("movback.asm", FASM .. " %f %o " .. tup.getconfig("KPACK_CMD"), "movback")`
IgorA commented 2025-03-17 18:43:37 +01:00
Author
Member
Copy Link

fix Tupfile.lua

fix Tupfile.lua
dunkaist commented 2025-03-17 19:22:37 +01:00
Owner
Copy Link

Thank you

Thank you
mxlgv added the
PR
Request changes
 label 2025-03-17 08:09:55 +01:00
mxlgv changed title from update-movback to Movback: Added support window resizing 2025-03-17 08:26:51 +01:00
mxlgv requested review from mxlgv 2025-03-17 17:31:43 +01:00
mxlgv requested changes 2025-03-17 17:32:52 +01:00
Dismissed
mxlgv left a comment
Owner
Copy Link

Please correct the PR as requested by the reviewer.

Please correct the PR as requested by the reviewer.
IgorA force-pushed update-movback from 5a907e131b to 34093cd781 2025-03-17 17:59:17 +01:00 Compare
IgorA force-pushed update-movback from 34093cd781 to 49a67600fb 2025-03-17 18:05:44 +01:00 Compare
IgorA force-pushed update-movback from 49a67600fb to d7d1a95215 2025-03-17 20:51:00 +01:00 Compare
dunkaist approved these changes 2025-03-17 21:03:49 +01:00
Dismissed
mxlgv approved these changes 2025-03-17 22:23:14 +01:00
Dismissed
mxlgv added
PR
Ready to merge
 and removed
PR
Request changes
 labels 2025-03-17 22:23:24 +01:00
mxlgv force-pushed update-movback from d7d1a95215 to 63cd6f0ac8 2025-03-17 22:31:49 +01:00 Compare
mxlgv dismissed dunkaist’s review 2025-03-17 22:31:50 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

mxlgv dismissed mxlgv’s review 2025-03-17 22:31:50 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

mxlgv scheduled this pull request to auto merge when all checks succeed 2025-03-17 22:32:15 +01:00
mxlgv approved these changes 2025-03-17 23:07:54 +01:00
mxlgv merged commit 63cd6f0ac8 into main 2025-03-17 23:08:03 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
PR
Ready to merge
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#160
No description provided.
Delete Branch "update-movback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?