KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

Laser Tank: fix window height for a various skin height #179

Closed
Leency wants to merge 1 commits from laser-tank-fix-win-height into main
pull from: laser-tank-fix-win-height
merge into: KolibriOS:main
Conversation 4 Commits 1 Files Changed 1 +1 -4
Leency commented 2025-03-26 00:39:18 +01:00
Owner
Copy Link
No description provided.
Screenshot_3.png
13 KiB
Screenshot_3.png
Leency added 1 commit 2025-03-26 00:39:20 +01:00
Laser Tank: fix window height for a various skin height
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 32s
Details
Build system / Build (pull_request) Successful in 5m2s
Details
b986b99735
mxlgv requested changes 2025-03-28 15:34:08 +01:00
mxlgv left a comment
Owner
Copy Link

CI doesn't have MSVC. Have you actually configured MSVC and built locally? It would be great if you could attach the compiled binary for testing.

CI doesn't have MSVC. Have you actually configured MSVC and built locally? It would be great if you could attach the compiled binary for testing.
mxlgv added the
PR
Request changes
 label 2025-03-28 15:36:11 +01:00
Leency commented 2025-03-28 15:43:44 +01:00
Author
Owner
Copy Link

CI doesn't have MSVC. Have you actually configured MSVC and built locally? It would be great if you could attach the compiled binary for testing.

Sorry, I don't have MSVC.

> CI doesn't have MSVC. Have you actually configured MSVC and built locally? It would be great if you could attach the compiled binary for testing. Sorry, I don't have MSVC.
mxlgv commented 2025-03-30 15:35:15 +02:00
Owner
Copy Link

Let's postpone it until MSVC is added to CI.

Let's postpone it until MSVC is added to CI.
mxlgv added
PR
Dependent
 and removed
PR
Request changes
 labels 2025-03-30 15:35:37 +02:00
mxlgv added the
Category/Applications
 label 2025-03-30 16:16:52 +02:00
Sweetbread added the
Status
Blocked
 label 2025-03-30 16:37:08 +02:00
Sweetbread added a new dependency 2025-03-30 16:37:12 +02:00
#184 CI: Requires MSVC to be added
mxlgv commented 2025-04-01 17:34:45 +02:00
Owner
Copy Link

Changes to the MSVC program will no longer be accepted. Some must be rewritten in GCC.

Changes to the MSVC program will no longer be accepted. Some must be rewritten in GCC.
mxlgv closed this pull request 2025-04-01 17:34:50 +02:00
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 32s
Required
Details
Build system / Build (pull_request) Successful in 5m2s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Category/Applications
PR
Dependent
Status
Blocked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Depends on
#184 CI: Requires MSVC to be added
KolibriOS/kolibrios
Reference: KolibriOS/kolibrios#179
No description provided.
Delete Branch "laser-tank-fix-win-height"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?