KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

Move Period app (RUS only!) to ISO #186

Merged
mxlgv merged 1 commits from period-move-to-img into main 2025-04-03 10:07:23 +02:00
Conversation 4 Commits 1 Files Changed 1 +1 -1
Leency commented 2025-03-31 00:44:42 +02:00
Owner
Copy Link

Move data to a separate file

Move data to a separate file
Leency added 1 commit 2025-03-31 00:44:45 +02:00
move Period app (RUS only!) to ISO
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 32s
Details
Build system / Build (pull_request) Successful in 6m52s
Details
dec2f51d0b
mxlgv added the
PR
Review required
 label 2025-03-31 08:44:26 +02:00
mxlgv requested changes 2025-03-31 11:00:34 +02:00
Dismissed
mxlgv left a comment
Owner
Copy Link

Not only have you moved this application to an ISO, but you have also made significant changes. Please describe them. At least in the PR text.

Not only have you moved this application to an ISO, but you have also made significant changes. Please describe them. At least in the PR text.
mxlgv added
PR
Request changes
 and removed
PR
Review required
 labels 2025-03-31 11:00:47 +02:00
mxlgv changed title from move Period app (RUS only!) to ISO to Move Period app (RUS only!) to ISO 2025-03-31 11:01:00 +02:00
Leency commented 2025-04-03 09:14:50 +02:00
Author
Owner
Copy Link

Not only have you moved this application to an ISO, but you have also made significant changes. Please describe them. At least in the PR text.

Added

> Not only have you moved this application to an ISO, but you have also made significant changes. Please describe them. At least in the PR text. Added
mxlgv force-pushed period-move-to-img from dec2f51d0b to 50b948e8da 2025-04-03 09:55:21 +02:00 Compare
mxlgv force-pushed period-move-to-img from 50b948e8da to 00c2cfbcfc 2025-04-03 10:00:43 +02:00 Compare
mxlgv commented 2025-04-03 10:05:40 +02:00
Owner
Copy Link

The main change is moving the program from IMG to ISO. I think that there is no need to make minor edits if it does not, for example, fix a bug. I am also against moving huge arrays of code. This does not affect the functionality of the program, but on the contrary, only confuses the history of changes. The convenience of having some data in another file is extremely subjective.

The main change is moving the program from IMG to ISO. I think that there is no need to make minor edits if it does not, for example, fix a bug. I am also against moving huge arrays of code. This does not affect the functionality of the program, but on the contrary, only confuses the history of changes. The convenience of having some data in another file is extremely subjective.
mxlgv approved these changes 2025-04-03 10:05:53 +02:00
mxlgv scheduled this pull request to auto merge when all checks succeed 2025-04-03 10:06:09 +02:00
mxlgv added
PR
Ready to merge
 and removed
PR
Request changes
 labels 2025-04-03 10:06:20 +02:00
mxlgv canceled auto merging this pull request when all checks succeed 2025-04-03 10:07:18 +02:00
mxlgv merged commit 00c2cfbcfc into main 2025-04-03 10:07:23 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
PR
Ready to merge
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#186
No description provided.
Delete Branch "period-move-to-img"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?