KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

Kernel: Fix bug #221 - accept does not fill sockaddr #227

Merged
mxlgv merged 1 commits from fix_accept into main 2025-05-05 18:14:27 +02:00
Conversation 5 Commits 1 Files Changed 1 +23
Doczom commented 2025-05-03 20:55:18 +02:00
Owner
Copy Link

fixed #221

fixed https://git.kolibrios.org/KolibriOS/kolibrios/issues/221
Doczom added 1 commit 2025-05-03 20:55:21 +02:00
Krn: Fixed the "accept" network function. Added getting remote client data.
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 37s
Details
Build system / Build (pull_request) Successful in 5m28s
Details
66fed2a491
Doczom added the
Category/Kernel
Kind
Breaking
 labels 2025-05-04 09:46:27 +02:00
mxlgv requested changes 2025-05-04 19:01:10 +02:00
Dismissed
mxlgv left a comment
Owner
Copy Link

Please reduce commit header https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/CONTRIBUTING.md#length

Please reduce commit header https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/CONTRIBUTING.md#length
mxlgv requested changes 2025-05-04 19:02:45 +02:00
Dismissed
kernel/trunk/network/socket.inc
@@ -699,0 +703,4 @@
test edx, edx
jz .skip_sockaddr
mov word[edx], 0 ; unknowe domain
mxlgv commented 2025-05-04 19:02:41 +02:00
Owner
Copy Link

'e' is an typo?

'e' is an typo?
mxlgv marked this conversation as resolved
mxlgv requested changes 2025-05-04 19:04:16 +02:00
Dismissed
mxlgv left a comment
Owner
Copy Link

It seems like a test program is needed to check this. Can you attach an example here?

It seems like a test program is needed to check this. Can you attach an example here?
Doczom closed this pull request 2025-05-04 19:36:20 +02:00
mxlgv reopened this pull request 2025-05-05 17:55:02 +02:00
mxlgv changed title from Krn: Fixed the "accept" network function. Added getting remote client data. to Kernel: Fixed bug #221 - accept does not fill sockaddr 2025-05-05 17:55:48 +02:00
mxlgv added a new dependency 2025-05-05 18:07:47 +02:00
#221 Network: bug in accept function
mxlgv commented 2025-05-05 18:11:42 +02:00
Owner
Copy Link

Tested using httpd from issue attachments in WebView: http://127.0.0.1:8181/ip.

To:

<p> ip 0.0.0.0 port:0 </p>

After

<p> ip 127.0.0.1 port:56553 </p>
Tested using httpd from [issue](https://git.kolibrios.org/KolibriOS/kolibrios/issues/221) attachments in WebView: `http://127.0.0.1:8181/ip`. To: ```html <p> ip 0.0.0.0 port:0 </p> ``` After ```html <p> ip 127.0.0.1 port:56553 </p> ```
mxlgv approved these changes 2025-05-05 18:12:02 +02:00
mxlgv removed a dependency 2025-05-05 18:13:44 +02:00
#221 Network: bug in accept function
Sweetbread changed title from Kernel: Fixed bug #221 - accept does not fill sockaddr to Kernel: Fix bug #221 - accept does not fill sockaddr 2025-05-05 18:13:54 +02:00
mxlgv added the
PR
Ready to merge
 label 2025-05-05 18:14:17 +02:00
mxlgv merged commit 51b150c9aa into main 2025-05-05 18:14:27 +02:00
mxlgv deleted branch fix_accept 2025-05-05 18:14:27 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Category/Kernel
Kind
Breaking
PR
Ready to merge
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#227
No description provided.
Delete Branch "fix_accept"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?