KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

FTPC: Fixed crash on large directories #243

Merged
Doczom merged 1 commits from b00bl1k/kolibrios:207-fix-ftpc-crash into main 2025-06-12 19:31:34 +02:00
Conversation 4 Commits 1 Files Changed 1 +4
b00bl1k commented 2025-05-18 21:02:52 +02:00
Contributor
Copy Link

Fixed a crash in the FTPC application when parsing large directories, in cases where the file name is truncated due to buffer size.

Closes #207

Fixed a crash in the FTPC application when parsing large directories, in cases where the file name is truncated due to buffer size. Closes #207
b00bl1k added 2 commits 2025-05-18 21:02:56 +02:00
Fix ftpc crash ac1055064d
Remove unused file
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 36s
Details
Build system / Build (pull_request) Successful in 5m34s
Details
4c371a8101
b00bl1k requested review from mxlgv 2025-05-18 21:03:18 +02:00
mxlgv added the
Category/Applications
FASM
PR
Review required
 labels 2025-05-20 21:58:47 +02:00
mxlgv force-pushed 207-fix-ftpc-crash from 4c371a8101 to 98988e9d5c 2025-05-20 22:06:03 +02:00 Compare
mxlgv requested changes 2025-05-20 22:09:34 +02:00
mxlgv left a comment
Owner
Copy Link

Please do not add unrelated changes to PRs. Keep one commit that fixes the issue.

Please do not add unrelated changes to PRs. Keep one commit that fixes the issue.
mxlgv added
PR
Request changes
 and removed
PR
Review required
 labels 2025-05-20 22:09:44 +02:00
b00bl1k force-pushed 207-fix-ftpc-crash from 98988e9d5c to 123320d145 2025-05-20 23:05:45 +02:00 Compare
b00bl1k requested review from mxlgv 2025-05-20 23:12:32 +02:00
Burer approved these changes 2025-06-01 14:22:49 +02:00
Burer left a comment
Owner
Copy Link

Tested with problematic folder from #207 and with multiple folders from KolibriOS ftp server, everything seems to be working good.

Tested with problematic folder from #207 and with multiple folders from KolibriOS ftp server, everything seems to be working good.
b00bl1k removed review request for mxlgv 2025-06-11 19:19:39 +02:00
b00bl1k requested review from Doczom 2025-06-11 19:19:42 +02:00
b00bl1k requested review from rgimad 2025-06-11 19:19:43 +02:00
rgimad approved these changes 2025-06-11 19:34:39 +02:00
Doczom approved these changes 2025-06-12 17:18:43 +02:00
Doczom merged commit 11562988b1 into main 2025-06-12 19:31:34 +02:00
b00bl1k deleted branch 207-fix-ftpc-crash 2025-06-12 20:07:12 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
Burer
rgimad
Doczom
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Category/Applications
FASM
PR
Request changes
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#243
No description provided.
Delete Branch "b00bl1k/kolibrios:207-fix-ftpc-crash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?