KolibriOS/kolibrios
18
28 Fork 71
Code Issues 155 Pull Requests 68 Actions Projects 2 Releases Wiki Activity

apps/webview: added search / go buttons, added text analysis for the entered text in the omni box (fix #111) #377

Merged
Burer merged 9 commits from Marouane-Djabri/kolibrios:Search-UI-UX-improvement into main 2026-03-29 09:33:19 +00:00
Conversation 6 Commits 9 Files Changed 2
+57 -33
Marouane-Djabri commented 2026-03-18 00:14:55 +00:00
Contributor
Copy link
Copy source
image.png
<img width="100%" alt="image.png" src="attachments/a14500c3-67a8-4a2f-913e-44d0f006ae6a">
image.png
25 KiB
Marouane-Djabri added 1 commit 2026-03-18 00:14:56 +00:00
added search / go buttons, added text analysis for the entered text in the omni box (fix #111)
Build system / Check kernel codestyle (pull_request) Successful in 1m36s
Details
Build system / Build (pull_request) Successful in 11m40s
Details
55b31070b1
Burer changed title from WIP: added search / go buttons, added text analysis for the entered text in the omni box (fix #111) to WIP: apps/webview: added search / go buttons, added text analysis for the entered text in the omni box (fix #111) 2026-03-18 06:50:08 +00:00
Burer requested changes 2026-03-18 07:20:11 +00:00
Dismissed
programs/cmm/browser/WebView.c Outdated
@@ -371,6 +396,13 @@ void SetElementSizes()
WB1.list.visible = WB1.list.h;
}
int DrawButton3D(dword _x, _y, _w, _h, _id, _col)
Burer commented 2026-03-18 07:19:52 +00:00
Owner
Copy link
Copy source

I see no reason to add separate function for buttons drawing.
You can make them just the same as current buttons on navigation panel.
It will not only make UI more consistent, but also save limited space of floppy image.
image.png

I see no reason to add separate function for buttons drawing. You can make them just the same as current buttons on navigation panel. It will not only make UI more consistent, but also save limited space of floppy image. <img width="450" alt="image.png" src="attachments/747666d2-0856-4fa1-89d1-3e915e0e8c48">
image.png
9.2 KiB
Burer marked this conversation as resolved
programs/cmm/browser/const.h Outdated
@@ -14,3 +14,2 @@
-
Посмотреть исходник|Ctrl+U
Редактировать исходник|F2";
��ᬮ���� ��室���|Ctrl+U
Burer commented 2026-03-18 07:17:15 +00:00
Owner
Copy link
Copy source

Looks like you changes encoding for all localization strings.
If it is done accidentaly - please, revert these changes.

Looks like you changes encoding for all localization strings. If it is done accidentaly - please, revert these changes.
Burer marked this conversation as resolved
Marouane-Djabri started working 2026-03-18 12:17:19 +00:00
Marouane-Djabri added 1 commit 2026-03-18 12:57:56 +00:00
changed the methode for drawing the buttons and fixed the go button
Build system / Check kernel codestyle (pull_request) Successful in 26s
Details
Build system / Build (pull_request) Successful in 10m11s
Details
323ff55f31
Marouane-Djabri commented 2026-03-18 13:00:46 +00:00
Author
Contributor
Copy link
Copy source

i have addressed the the requested changes

i have addressed the the requested changes
Marouane-Djabri worked for 43 minutes 2026-03-18 13:01:08 +00:00
Marouane-Djabri added 1 commit 2026-03-18 14:03:52 +00:00
changed the definition of the constants to dword and removed duplicate function
Build system / Check kernel codestyle (pull_request) Successful in 28s
Details
Build system / Build (pull_request) Successful in 10m10s
Details
959bbcaf44
Marouane-Djabri added 1 commit 2026-03-18 14:27:11 +00:00
removed extra spaces and removed duplicates
Build system / Check kernel codestyle (pull_request) Successful in 24s
Details
Build system / Build (pull_request) Failing after 51s
Details
6a791edceb
Marouane-Djabri added 1 commit 2026-03-18 14:37:01 +00:00
removed .com file
Build system / Build (pull_request) Successful in 10m18s
Details
Build system / Check kernel codestyle (pull_request) Successful in 25s
Details
233876d8dd
Burer added 1 commit 2026-03-18 14:51:33 +00:00
apps/webview: some fixes in PR
Build system / Check kernel codestyle (pull_request) Successful in 58s
Details
Build system / Build (pull_request) Successful in 10m54s
Details
fb7fdd9bc3
Burer added 1 commit 2026-03-18 15:44:29 +00:00
apps/webview: some code optimizations
Build system / Check kernel codestyle (pull_request) Successful in 25s
Details
Build system / Build (pull_request) Successful in 10m25s
Details
26c9785ba2
Burer marked the pull request as ready for review 2026-03-18 18:45:40 +00:00
Burer approved these changes 2026-03-18 18:46:31 +00:00
Dismissed
mxlgv left a comment
Owner
Copy link
Copy source

You need to change the application version.

You need to change the application version.
Marouane-Djabri added 1 commit 2026-03-27 12:30:52 +00:00
updated the version to 3.93
Build system / Check kernel codestyle (pull_request) Successful in 56s
Details
Build system / Build (pull_request) Successful in 10m42s
Details
803af4ffae
Marouane-Djabri added 1 commit 2026-03-27 12:43:26 +00:00
merge upstream
Build system / Check kernel codestyle (pull_request) Successful in 48s
Details
Build system / Build (pull_request) Successful in 10m18s
Details
965c253579
Marouane-Djabri commented 2026-03-28 13:23:34 +00:00
Author
Contributor
Copy link
Copy source

changes done

changes done
Burer approved these changes 2026-03-29 09:31:27 +00:00
Burer merged commit b5981a39dc into main 2026-03-29 09:33:19 +00:00
Burer deleted branch Search-UI-UX-improvement 2026-03-29 09:33:24 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
Burer
Labels
Clear labels
Influence/Text/TYPO
AI
Eolite
FS
GSoC
This issue or PR in the Google Source of Code program
 Good First PR
The issue is suitable to beginners
 HLL
HardwareTested
IRCC
Influence/Settings
Lang/C
Lang/FASM
Pay for the code
Paid task
 Subsystem/API
Subsystem/Audio
infinity service, audio drivers, midi, speacker, audio programs
 Subsystem/Graphics
vesa, vga, framebuffer, cursors, blitter, and video drivers
 Subsystem/IPC and events
pipes, signals, events, shared memory
 Subsystem/Memory
virt and phys memory allocators, malloc and other
 Subsystem/Network
Subsystem/Services(daemon)
userspace and kernel(for example: serial) services
 Subsystem/Taskmanager
process, threads, run apps, scheduler
 Subsystem/VFS
drivers from filesystem, fs api, blkdev, programs that work with the file system
 Subsystem/Window
windows, skins, buttons, mouse and keyboard code for windows (not the base code)
Category
Applications
Category
Drivers
Category
General
Category
Kernel
Category
Libraries
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
PR
Ready to merge
Pull request is ready for merge
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
PR
Request changes
Changes requested in pull request
PR
Review required
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
ace-dent (Andrew) b00bl1k (Alexey Ryabov) bad_Dr3dd0x Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор Ярин) hidnplayr IgorA kolibrios-bot Bot mxlgv (Max Logaev) ramenu raTaHoa90 (Сергеев Данила) rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
3 Participants
Notifications
Total Time Spent: 43 minutes
Marouane-Djabri
43 minutes
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#377