libs/iconv: fix to/from unpacking order and calling convention (fix #126) (fix #127) #387

2026-03-23T03:45:54Z

sebastianting commented

2026-03-23 03:45:54 +00:00

 swapped unpacking order of to and from and caller parameters
 
 removed null terminator adding at end
 
 changed call from stdcall to cdecl

swapped unpacking order of to and from and caller parameters removed null terminator adding at end changed call from stdcall to cdecl

sebastianting marked the pull request as ready for review 2026-03-23 03:46:38 +00:00

mxlgv approved these changes

2026-03-27 01:07:09 +00:00

Burer changed title from ~~fix: iconv to/from unpacking order and calling convention (#126) (#127)~~ to libs/iconv: fix to/from unpacking order and calling convention (fix #126) (fix #127)

2026-03-31 08:10:28 +00:00

Burer added 1 commit 2026-03-31 08:11:47 +00:00

fix: iconv to/from unpacking order and calling convention (#126 ) (#127 )

Build system / Check kernel codestyle (pull_request) Successful in 1m32s

Details

Build system / Build (pull_request) Successful in 11m41s

Details

de6724017d

swapped unpacking order of to and from and caller parameters
     removed null terminator adding at end
     changed call from stdcall to cdecl

Burer force-pushed fix-iconv-order from eb01620450 to de6724017d

2026-03-31 08:11:47 +00:00

Compare

Burer approved these changes

2026-03-31 08:30:11 +00:00

Burer merged commit de6724017d into main

2026-03-31 08:30:52 +00:00

Burer deleted branch fix-iconv-order

2026-03-31 08:31:22 +00:00

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#387

Allow edits from maintainers