KolibriOS/kolibrios
18
28 Fork 71
Code Issues 155 Pull Requests 71 Actions Projects 2 Releases Wiki Activity

Kernel/fs: Add symlink flag to sysfunc70 and update the English documentation #656

Merged
Doczom merged 2 commits from Matou1306/kolibrios:ext-symlinks into main 2026-09-20 04:46:25 +00:00
Conversation 6 Commits 2 Files Changed 2
+7
Matou1306 commented 2026-08-23 13:20:38 +00:00
Contributor
Copy link
Copy source

Used in 70.1 and 70.5 in the ext driver

Used in 70.1 and 70.5 in the ext driver
👍 2
Matou1306 requested review from Burer 2026-08-23 13:20:56 +00:00
Matou1306 requested review from Doczom 2026-08-23 13:20:56 +00:00
Matou1306 requested review from dunkaist 2026-08-23 13:20:57 +00:00
Doczom approved these changes 2026-08-27 12:47:56 +00:00
Dismissed
Burer left a comment
Owner
Copy link
Copy source

🟡 ext_GetFileInfo hunk is dead code. ext_GetFileInfo goes through findInode, which always resolves the final symlink for normal calls - symlink_no_follow is only set via the reachSymlink entry used by SF 70.12. By the time the new check runs, inodeBuffer holds the target inode, so accessMode & TYPE_MASK can never equal FLAG_SYMLINK (a dangling symlink errors out earlier), and the flag will never appear in 70.5 output. Either drop the hunk, or - if the intent is lstat-like semantics for 70.5 - that is a behavior change worth a separate discussion.

🔵 Doc: mark the bit as ext-only. Worth noting in sysfuncs.txt that bit 6 is currently set only by the ext driver - FAT/NTFS/exFAT/XFS leave it clear.

🟡 **`ext_GetFileInfo` hunk is dead code.** `ext_GetFileInfo` goes through `findInode`, which always resolves the *final* symlink for normal calls - `symlink_no_follow` is only set via the `reachSymlink` entry used by SF 70.12. By the time the new check runs, `inodeBuffer` holds the *target* inode, so `accessMode & TYPE_MASK` can never equal `FLAG_SYMLINK` (a dangling symlink errors out earlier), and the flag will never appear in 70.5 output. Either drop the hunk, or - if the intent is lstat-like semantics for 70.5 - that is a behavior change worth a separate discussion. 🔵 **Doc: mark the bit as ext-only.** Worth noting in sysfuncs.txt that bit 6 is currently set only by the ext driver - FAT/NTFS/exFAT/XFS leave it clear.
Matou1306 force-pushed ext-symlinks from aca7e52cdb to 74dede3a75 2026-08-28 13:40:07 +00:00 Compare
Matou1306 commented 2026-08-28 13:47:23 +00:00
Author
Contributor
Copy link
Copy source

Hello @Burer thanks for catching that, I implemented your first suggestion for now.
I feel like being able to return the fact that the file is a symlink would be beneficial for file managers (for example to be able to inherit the file type of the target and open automatically with the default app for it). This will need changes to file managers as well, it would be good to discuss it later outside the scope of this PR.

Hello @Burer thanks for catching that, I implemented your first suggestion for now. I feel like being able to return the fact that the file is a symlink would be beneficial for file managers (for example to be able to inherit the file type of the target and open automatically with the default app for it). This will need changes to file managers as well, it would be good to discuss it later outside the scope of this PR.
👍 1
Doczom commented 2026-08-28 14:35:43 +00:00
Owner
Copy link
Copy source

Doc: mark the bit as ext-only. Worth noting in sysfuncs.txt that bit 6 is currently set only by the ext driver - FAT/NTFS/exFAT/XFS leave it clear.

Many file systems support symbolic links, so such a note is unnecessary, as is mentioning in each subfunction that error 2 will be displayed for CD discs.

> Doc: mark the bit as ext-only. Worth noting in sysfuncs.txt that bit 6 is currently set only by the ext driver - FAT/NTFS/exFAT/XFS leave it clear. > Many file systems support symbolic links, so such a note is unnecessary, as is mentioning in each subfunction that error 2 will be displayed for CD discs.
dunkaist approved these changes 2026-09-13 19:21:26 +00:00
Doczom approved these changes 2026-09-18 17:25:37 +00:00
Doczom force-pushed ext-symlinks from 74dede3a75 to 30cb00b238 2026-09-19 18:38:00 +00:00 Compare
CODEOWNERS rules requested review from system 2026-09-19 18:38:00 +00:00
Doczom added 2 commits 2026-09-20 04:40:31 +00:00
Add symlink flag to sysfunc70 and update the documentation dc7c833912
Drop ext_GetFileInfo symlink flag check
Check kernel codestyle / Check kernel codestyle (pull_request) Successful in 19s
Details
Test PR / Build (en_US) (pull_request) Successful in 1m59s
Details
Test PR / Build (es_ES) (pull_request) Successful in 2m3s
Details
Test PR / Build (ru_RU) (pull_request) Successful in 2m10s
Details
43ad2ab592 
add that bit 6 in syfunc 70 is only set by ext driver
Doczom force-pushed ext-symlinks from 30cb00b238 to 43ad2ab592 2026-09-20 04:40:31 +00:00 Compare
Doczom merged commit ecdebae231 into main 2026-09-20 04:46:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Burer
dunkaist
Doczom
KolibriOS/system
Labels
Clear labels
Influence/Text/TYPO
AI
Eolite
FS
GSoC
This issue or PR in the Google Source of Code program
 Good First PR
The issue is suitable to beginners
 HLL
HardwareTested
IRCC
Influence/Settings
Lang/C
Lang/FASM
Pay for the code
Paid task
 Subsystem/API
Subsystem/Audio
infinity service, audio drivers, midi, speacker, audio programs
 Subsystem/Graphics
vesa, vga, framebuffer, cursors, blitter, and video drivers
 Subsystem/IPC and events
pipes, signals, events, shared memory
 Subsystem/Memory
virt and phys memory allocators, malloc and other
 Subsystem/Network
Subsystem/Services(daemon)
userspace and kernel(for example: serial) services
 Subsystem/Taskmanager
process, threads, run apps, scheduler
 Subsystem/VFS
drivers from filesystem, fs api, blkdev, programs that work with the file system
 Subsystem/Window
windows, skins, buttons, mouse and keyboard code for windows (not the base code)
Category
Applications
Category
Drivers
Category
General
Category
Kernel
Category
Libraries
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
PR
Ready to merge
Pull request is ready for merge
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
PR
Request changes
Changes requested in pull request
PR
Review required
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
ace-dent (Andrew) b00bl1k (Alexey Ryabov) bad_Dr3dd0x Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор Ярин) hidnplayr IgorA kolibrios-bot Bot mxlgv (Max Logaev) ramenu raTaHoa90 (Сергеев Данила) rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#656