Apps/sysmon: Fixed #85 #86

Burer · 2024-07-30T16:02:43+02:00

Burer commented

2024-07-30 16:02:43 +02:00

First-time contributor

Small code changes to fix all issues mentioned in Issue #85:

Bumped app version and added it to header.
Changed system disk usage subscription from MB to KB in English version.
Properly aligned CPU usage percents in process list with header.
Free space on disks now rounds down, instead of rounding app.
Small formatting fixes.
Fixed wrong language set in English version of compilation script.

WARNING!

For some reason, on my system, even unmodified source code is build with bug - CPU load per process is always 0 or 1. I believe, that reason is in some type of overloading, as when I tried to display maximum number of CPU cycles I got just big negative value.

However, since the autobuild system builds these same sources without problems, there must be some local bug or compiler misconfiguration, so I assume that my updated code should also be built by the autobuild system without problems. But I am not sure about it, so it is advisable to check it before accepting this Pull Request.

Small code changes to fix all issues mentioned in Issue #85: - Bumped app version and added it to header. - Changed system disk usage subscription from MB to KB in English version. - Properly aligned CPU usage percents in process list with header. - Free space on disks now rounds down, instead of rounding app. - Small formatting fixes. - Fixed wrong language set in English version of compilation script. **WARNING!** For some reason, on my system, even unmodified source code is build with bug - CPU load per process is always 0 or 1. I believe, that reason is in some type of overloading, as when I tried to display maximum number of CPU cycles I got just big negative value. However, since the autobuild system builds these same sources without problems, there must be some local bug or compiler misconfiguration, so I assume that my updated code should also be built by the autobuild system without problems. But I am not sure about it, so it is advisable to check it before accepting this Pull Request.

system_monitor_bug_6.png

125 KiB

Burer added 1 commit 2024-07-30 16:03:12 +02:00

Fixed #85 (Various problems in System Monitor) 3129b611d1

Small code changes to fix all issues mentioned in Issue #85:
- Bumped app version and added it to header.
- Changed system disk usage subscription from MB to KB in English version.
- Properly aligned CPU usage percents in process list with header.
- Free space on disks now rounds down, instead of rounding app.
- Small formatting fixes.

Burer changed title from ~~WIP: Fixed #85 (Various problems in System Monitor)~~ to Fixed #85 (Various problems in System Monitor)

2024-07-30 16:03:35 +02:00

mxlgv commented

2024-11-13 21:32:56 +01:00

@Burer Please edit the commit message to Apps/sysmon: Fixed #85.

@Burer Please edit the commit message to `Apps/sysmon: Fixed #85`.

mxlgv requested review from mxlgv 2024-11-13 21:33:06 +01:00

Burer changed title from ~~Fixed #85 (Various problems in System Monitor)~~ to Apps/sysmon: Fixed #85

2024-11-14 14:10:07 +01:00

Burer commented

2024-11-14 14:11:52 +01:00

First-time contributor

@Burer Please edit the commit message to Apps/sysmon: Fixed #85.

Done!
It is not WIP, as I have already done all fixes that I want. But please, check if app builds and works okay before merging this commit, because for me even unmodified sources haven't built properly as stated in warning in pull request description.

> @Burer Please edit the commit message to `Apps/sysmon: Fixed #85`. Done! It is not WIP, as I have already done all fixes that I want. But please, check if app builds and works okay before merging this commit, because for me even unmodified sources haven't built properly as stated in warning in pull request description.

Burer changed title from ~~Apps/sysmon: Fixed #85~~ to WIP: Apps/sysmon: Fixed #85

2024-11-14 14:13:06 +01:00

Burer changed title from ~~WIP: Apps/sysmon: Fixed #85~~ to Apps/sysmon: Fixed #85

2024-11-14 14:13:18 +01:00

Burer force-pushed main from 3129b611d1 to cd0534afb1

2024-11-15 19:11:58 +01:00

Compare

Sweetbread reviewed 2024-11-15 19:32:59 +01:00

programs/cmm/sysmon/sysmon.c

						
				@ -312,3 +312,4 @@

					dir_size.get(#param);

					dir_size.sizelo += dir_size.files/2 + 32 * 512; //file attr size + FAT table size

					dir_size.sizelo += 1024*1024 - 1; // add this line to round up

					dir_size.sizelo /= 1024*1024; //convert to MiB

Sweetbread commented

2024-11-15 19:32:59 +01:00

Shows in KB, but converts to MiB?

Burer commented

2024-11-15 20:08:27 +01:00

First-time contributor

System disc free space was calculated and shown in KiB, but subscripted in MB. I changed it's subscription to KB.
TMP discs free space was shown and subscripted in MiB, but I changed it's logic from round-up to round-down.

These are two different functions with different logic of work.

System disc free space was calculated and shown in KiB, but subscripted in MB. I changed it's subscription to KB. TMP discs free space was shown and subscripted in MiB, but I changed it's logic from round-up to round-down. These are two different functions with different logic of work.

👍 1

mxlgv approved these changes 2024-11-17 20:28:18 +01:00

mxlgv left a comment

I pre-approve. But it's better to wait until CI is working.

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u main:Burer-main

git checkout Burer-main

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#86