KolibriOS/kolibrios
12
4
Fork 11
Code Issues 78 Pull Requests 5 Projects Releases Activity

Libs/newlib: Fix sys/ksys.h -Wextra warnings. #90

Closed
Egor00f wants to merge 2 commits from Egor00f/kolibrios:main into main
pull from: Egor00f/kolibrios:main
merge into: KolibriOS:main
Conversation 4 Commits 2 Files Changed 1 +6 -5
Egor00f commented 2024-08-21 12:18:45 +02:00
Contributor
Copy Link

These warnings are starting to piss me off.
in line 519: just added parentheses
in line 1226: replaced movl 0x27(%%ebp), %%ebp to movl %0, %%ebp ::"X"(offset)

These warnings are starting to piss me off. in line 519: just added parentheses in line 1226: replaced `movl 0x27(%%ebp), %%ebp` to `movl %0, %%ebp ::"X"(offset)`
Egor00f added 1 commit 2024-08-21 12:19:25 +02:00 
just fix warnings: just added parentheses and fix Wunused-param offset
Egor00f added 1 commit 2024-08-21 12:31:59 +02:00
mxlgv commented 2024-11-13 22:17:29 +01:00
Owner
Copy Link

@Egor00f there are some notes:

  • Align comments in the code and remove irrelevant ones.
  • Replace commit message with "Libs/newlib: Fix sys/ksys.h -Wextra warnings.
  • Remove extra commit.
@Egor00f there are some notes: - Align comments in the code and remove irrelevant ones. - Replace commit message with "Libs/newlib: Fix sys/ksys.h -Wextra warnings. - Remove extra commit.
mxlgv requested review from mxlgv 2024-11-13 22:19:31 +01:00
Egor00f changed title from Fix sys/ksys.h -Wextra warnings to Libs/newlib: Fix sys/ksys.h -Wextra warnings. 2024-11-15 17:48:31 +01:00
Sweetbread commented 2024-11-15 17:50:30 +01:00
Owner
Copy Link

It's a PR, not a commit message

It's a PR, not a commit message
Egor00f commented 2024-11-17 08:17:55 +01:00
Author
Contributor
Copy Link

I'll finish it later

I'll finish it later
Egor00f closed this pull request 2024-11-17 08:17:55 +01:00
Egor00f commented 2024-11-17 10:23:50 +01:00
Author
Contributor
Copy Link

redid it properly in #93

redid it properly in https://git.kolibrios.org/KolibriOS/kolibrios/pulls/93

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
mxlgv
Labels
Clear labels   
C

   
Category/Applications

   
Category/Drivers

   
Category/General

   
Category/Kernel

   
Category/Libraries

   
Eolite

   
FASM

   
FS

   
HLL

   
Influence/Settings

   
Influence/Text/TYPO

   
IRCC

   
Kernel
  
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind
Build

  
Kind
Documentation
Documentation changes

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Security
This is security issue

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Kind
Bug
Kind
Build
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#90
No description provided.
Delete Branch "Egor00f/kolibrios:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?