KolibriOS/kolibrios
14
16
Fork 15
Code Issues 114 Pull Requests 14 Actions Projects 1 Releases Wiki Activity

Add serial ports driver #94

Merged
Sweetbread merged 4 commits from b00bl1k/kolibrios:add-serial-ports-driver into main 2025-01-12 13:28:51 +00:00
Conversation 4 Commits 4 Files Changed 6 +1901 -4
b00bl1k commented 2024-12-27 20:03:19 +00:00
Contributor
Copy Link

This pull request adds a new serial port driver that allows other drivers to add or remove ports dynamically and allows applications to use a single serial ports API. It also modifies the usbftdi driver to support the new serial ports API.

The driver may conflict with kernel if it is compiled with debug_com_base.

Topic on forum https://board.kolibrios.org/viewtopic.php?p=78764

This pull request adds a new serial port driver that allows other drivers to add or remove ports dynamically and allows applications to use a single serial ports API. It also modifies the usbftdi driver to support the new serial ports API. The driver may conflict with kernel if it is compiled with debug_com_base. Topic on forum https://board.kolibrios.org/viewtopic.php?p=78764
b00bl1k added 1 commit 2024-12-27 20:03:38 +00:00
Add initial implementation 86b4373721
b00bl1k added 1 commit 2024-12-29 18:11:59 +00:00
Fix driver name e0fc16dd5a
b00bl1k added 1 commit 2024-12-30 14:13:28 +00:00
Add func to change port settings 5a1bfc3f9b
Doczom added the
Kind
Feature
Priority
High
FASMCategory/Drivers labels 2025-01-01 19:09:16 +00:00
Doczom reviewed 2025-01-03 18:48:08 +00:00
drivers/serial/common.inc
@@ -0,0 +152,4 @@
mov eax, SF_SYS_MISC
mov ebx, SSF_CONTROL_DRIVER
lea ecx, [.handler]
int 0x40
Doczom commented 2025-01-03 18:48:07 +00:00
Owner
Copy Link

"int 0x40" should be replaced with the macro "mcall", passing all necessary arguments to this macro.

"int 0x40" should be replaced with the macro "mcall", passing all necessary arguments to this macro.
b00bl1k commented 2025-01-04 17:07:16 +00:00
Author
Contributor
Copy Link

Ok, done

Ok, done
Doczom marked this conversation as resolved
Doczom approved these changes 2025-01-03 18:53:34 +00:00
Dismissed
Doczom left a comment
Owner
Copy Link

The driver is working and can be added to the repository. But there are parts of the code where additional changes are possible.

The driver is working and can be added to the repository. But there are parts of the code where additional changes are possible.
b00bl1k added 1 commit 2025-01-04 17:05:42 +00:00
Use mcall macro, remove unused consts dbb1b6057d
b00bl1k changed title from WIP: Add serial ports driver to Add serial ports driver 2025-01-04 17:07:29 +00:00
Sweetbread approved these changes 2025-01-04 17:21:15 +00:00
Doczom requested review from Doczom 2025-01-04 18:03:03 +00:00
Doczom approved these changes 2025-01-04 18:04:22 +00:00
Sweetbread merged commit 5593d344cd into main 2025-01-12 13:28:51 +00:00
Sweetbread referenced this issue from a commit 2025-01-12 13:28:53 +00:00
Add serial ports driver
Sweetbread deleted branch add-serial-ports-driver 2025-01-12 13:30:03 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sweetbread
Doczom
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Category/Drivers FASM
Kind
Feature
Priority
High
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#94
Delete Branch "b00bl1k/kolibrios:add-serial-ports-driver"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?