Add filesystem syscall 70 wrapper and fs_demo example #10

2026-03-10T17:31:45Z

rajc6h6 commented

2026-03-10 17:31:45 +00:00

First-time contributor

src/fs.rs: wrapper for filesystem syscall 70 via int 0x40
examples/fs_demo.rs: reads /rd/1/readme.txt into a buffer
Builds with no_std + i686-kolibri target

- src/fs.rs: wrapper for filesystem syscall 70 via int 0x40 - examples/fs_demo.rs: reads /rd/1/readme.txt into a buffer - Builds with no_std + i686-kolibri target

rajc6h6 added 1 commit 2026-03-10 17:31:47 +00:00

Add filesystem syscall 70 wrapper and fs_demo example 1ea751f931

Sweetbread requested changes

2026-03-20 10:43:34 +00:00

Sweetbread left a comment

The way you wrote a wrapper does not fit the project

examples/fs_demo.rs

						
				@@ -0,0 +3,4 @@

				use kos::fs::{FileInfo, fs_read};

				static FILENAME: &[u8] = b"/rd/1/readme.txt\0";

Sweetbread commented

2026-03-20 10:40:24 +00:00

Use c"..." for c-strings

Use `c"..."` for c-strings

Sweetbread marked this conversation as resolved

examples/fs_demo.rs Outdated

						
				@@ -0,0 +8,4 @@

				#[no_mangle]

				pub extern "C" fn _start() -> ! {

				    unsafe {

Sweetbread commented

2026-03-20 10:41:36 +00:00

In examples should not be unsafes

In examples should not be `unsafe`s

Sweetbread marked this conversation as resolved

examples/fs_demo.rs Outdated

						
				@@ -0,0 +22,4 @@

				    }

				    loop {}

				}

Sweetbread commented

2026-03-20 10:40:32 +00:00

Add the example into Cargo.toml

Add the example into `Cargo.toml`

Sweetbread marked this conversation as resolved

src/fs.rs Outdated

						
				@@ -0,0 +9,4 @@

				    pub func:       u32,   // 0 = read, 1 = read folder, 2 = create/write

				    pub param1:     u32,   // offset (low)

				    pub param2:     u32,   // offset (high) or flags

				    pub param3:     u32,   // bytes to read/write

Sweetbread commented

2026-03-20 10:34:54 +00:00

Em? Why not just name them istead of writing comment?

Sweetbread marked this conversation as resolved

src/fs.rs Outdated

						
				@@ -0,0 +15,4 @@

				}

				/// Opens/reads a file on KolibriOS using syscall eax=70

				/// Returns (eax_result, ebx_bytes_read)

Sweetbread commented

2026-03-20 10:38:52 +00:00

That's too low-level. Those functions should be in src/sys.rs

That's too low-level. Those functions should be in `src/sys.rs`

Sweetbread marked this conversation as resolved

rajc6h6 added 1 commit 2026-03-21 07:18:10 +00:00

refactor: move raw syscall to sys.rs, safe fs_read API, c-string fix, named struct fields 922c05ceb6

rajc6h6 commented

2026-03-21 07:21:36 +00:00

First-time contributor

Done! I've made all the changes you requested:

Moved FileSystemRequest and raw syscall_fs to src/sys.rs

src/fs.rs now only has the safe fs_read API

Renamed struct fields properly instead of using comments

Switched to c"..." for C-strings

Removed all unsafe from the example

Added fs_demo to Cargo.toml

Let me know if there's anything else to fix!

Done! I've made all the changes you requested: Moved FileSystemRequest and raw syscall_fs to src/sys.rs src/fs.rs now only has the safe fs_read API Renamed struct fields properly instead of using comments Switched to c"..." for C-strings Removed all unsafe from the example Added fs_demo to Cargo.toml Let me know if there's anything else to fix!

Sweetbread requested changes

2026-03-22 17:51:59 +00:00

examples/fs_demo.rs Outdated

						
				@@ -0,0 +4,4 @@

				use kos::fs::fs_read;

				#[no_mangle]

				pub extern "C" fn _start() -> ! {

Sweetbread commented

2026-03-22 17:51:30 +00:00

Look at other examples for start command

Sweetbread marked this conversation as resolved

src/sys.rs Outdated

						
				@@ -71,0 +88,4 @@

				        in("ebx") req,

				        out("ebx") ebx_result,

				        options(nostack)

				    );

Sweetbread commented

2026-03-22 17:46:55 +00:00

You still have this kind of wrappers we don't use in the project

Sweetbread marked this conversation as resolved

rajc6h6 added 1 commit 2026-03-25 16:13:23 +00:00

fix: use syscalls.S FFI pattern for fs syscall, pub fn kol_main 819ffb3e5a

Sweetbread reviewed

2026-03-25 18:35:54 +00:00

src/syscalls.S Outdated

						
				@@ -145,1 +146,4 @@

				_fs_read:

				    push ebx

				    mov eax, 70

Sweetbread commented

2026-03-25 18:35:54 +00:00

Magic number. Use const SF_FILE

Magic number. Use const `SF_FILE`

Sweetbread marked this conversation as resolved

Sweetbread requested changes

2026-03-25 18:43:11 +00:00

Sweetbread left a comment

There are 10 subfuncs in syscall 70. You made too low-level wrapper with operation code in the struct. You shouldn't, because users of the library should not know any KOS's sysfuncs. So, I think, you should split it into 10 different Rust functions

src/sys.rs Outdated

						
				@@ -70,0 +80,4 @@

				    pub offset_hi:  u32,

				    pub byte_count: u32,

				    pub buffer:     *mut u8,

				    pub reserved:   u8,

Sweetbread commented

2026-03-25 18:38:31 +00:00

Why do you reserve it?

Sweetbread marked this conversation as resolved

rajc6h6 added 1 commit 2026-03-26 19:27:26 +00:00

fix: 10 separate fs functions, SF_FILE constant, pub(crate) FsBlock de15d645b4

rajc6h6 commented

2026-03-26 19:29:15 +00:00

First-time contributor

Fixed both issues:

mov eax, 70 replaced with mov eax, SF_FILE in syscalls.S

Redesigned fs module — 10 separate public functions (read_file, write_file, create_file, delete, create_folder, etc.), FsBlock is now pub(crate) so no KOS internals are exposed to library users

_pad byte kept internally to match the kernel ABI

Fixed both issues: mov eax, 70 replaced with mov eax, SF_FILE in syscalls.S Redesigned fs module — 10 separate public functions (read_file, write_file, create_file, delete, create_folder, etc.), FsBlock is now pub(crate) so no KOS internals are exposed to library users _pad byte kept internally to match the kernel ABI

You are not authorized to merge this pull request.

This pull request can be merged automatically.

This branch is out-of-date with the base branch

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u https://git.kolibrios.org/rajc6h6/Core feat/fs-syscall:rajc6h6-feat/fs-syscall

git checkout rajc6h6-feat/fs-syscall

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Rust/Core#10

Allow edits from maintainers