Rust/Core
1
1 Fork 4
Code Issues 7 Pull Requests 4 Releases Wiki Activity

add file sys calls #13

Open
BrokenC1oud wants to merge 1 commits from BrokenC1oud/Core:master into master
pull from: BrokenC1oud/Core:master
merge into: Rust:master
Conversation 1 Commits 1 Files Changed 5
+178
BrokenC1oud commented 2026-03-19 13:02:19 +00:00
First-time contributor
Copy link
Copy source

Hello, I'm BrokenC1oud, and I'm interested in participating in GSoC 2026.

Hello, I'm BrokenC1oud, and I'm interested in participating in GSoC 2026.
BrokenC1oud marked the pull request as work in progress 2026-03-20 05:17:50 +00:00
BrokenC1oud changed title from WIP: file sys calls to add file sys calls 2026-03-21 12:56:08 +00:00
Sweetbread left a comment
Owner
Copy link
Copy source
  1. You didn't provide an example
  2. You have a merge commit
1. You didn't provide an example 2. You have a merge commit
src/fs.rs
@@ -0,0 +4,4 @@
#[repr(C, packed)]
pub struct FileCommand {
pub func: u32, // 0 = read, 1 = read folder, 2 = create/write
Sweetbread commented 2026-03-21 21:28:28 +00:00
Owner
Copy link
Copy source

Should be an emum

Should be an emum
src/fs.rs
@@ -0,0 +7,4 @@
pub func: u32, // 0 = read, 1 = read folder, 2 = create/write
pub param1: u32, // offset (low)
pub param2: u32, // offset (high) or flags
pub param3: u32, // bytes to read/write
Sweetbread commented 2026-03-21 21:23:58 +00:00
Owner
Copy link
Copy source

Why not just name them?

Why not just name them?
BrokenC1oud commented 2026-03-23 02:15:27 +00:00
Author
First-time contributor
Copy link
Copy source

These parameters mean different things in different commands

These parameters mean different things in different commands
Sweetbread commented 2026-03-25 18:49:04 +00:00
Owner
Copy link
Copy source

Make different functions for different commands then

Make different functions for different commands then
BrokenC1oud commented 2026-03-26 00:45:54 +00:00
Author
First-time contributor
Copy link
Copy source

I don't get it, defining different structures makes it repetitive

I don't get it, defining different structures makes it repetitive
Sweetbread commented 2026-03-29 12:33:38 +00:00
Owner
Copy link
Copy source

I said functions, not structures. I definetely not allow structs with this names be in the repo

I said functions, not structures. I definetely not allow structs with this names be in the repo
BrokenC1oud commented 2026-03-30 14:26:51 +00:00
Author
First-time contributor
Copy link
Copy source

All file operations require the same struct
quoting this for modification doesn't make sense

All file operations require the same struct quoting this for modification doesn't make sense
BrokenC1oud force-pushed master from c023ca4534 to d47ee35fa5 2026-03-23 02:13:44 +00:00 Compare
You are not authorized to merge this pull request.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u https://git.kolibrios.org/BrokenC1oud/Core master:BrokenC1oud-master
git checkout BrokenC1oud-master
Sign in to join this conversation.
Reviewers
No Reviewers
Sweetbread
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Priority/Critical
The priority is critical
 Priority/High
The priority is high
 Priority/Low
The priority is low
 Priority/Medium
The priority is medium
 Reviewed/Confirmed
Issue has been confirmed
 Reviewed/Duplicate
This issue or pull request already exists
 Reviewed/Invalid
Invalid issue
 Reviewed/Won't Fix
This issue won't be fixed
 Status/Abandoned
Somebody has started to work on this but abandoned work
 Status/Blocked
Something is blocking this issue or pull request
 Status/Need More Info
Feedback is required to reproduce issue or to continue work
 Type/DLL
Type/High API
Type/Modules
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
Sweetbread (Gleb Zaharov)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rust/Core#13