Rust/Core
1
0
Fork 1
Code Issues 7 Pull Requests Releases Wiki Activity

feat: put_pixel #9

Merged
Sweetbread merged 2 commits from kohsine/Core:feature/put_pixel into feat/put_pixel 2024-04-01 12:58:34 +02:00
Conversation 6 Commits 2 Files Changed 5 +144
kohsine commented 2024-03-30 23:21:54 +01:00
Contributor
Copy Link

Mini PR to help out my GSoC app a bit and just for funsies.

Mini PR to help out my GSoC app a bit and just for funsies.
kohsine added 1 commit 2024-03-30 23:21:54 +01:00
feat: put_pixel 27ea16d171
Sweetbread requested changes 2024-03-31 11:04:27 +02:00
Sweetbread left a comment
Owner
Copy Link

You have a lot of unused imports and button handler. Also, Kolibri's API supports rectangle drawing: #13

You have a lot of unused imports and button handler. Also, Kolibri's API supports rectangle drawing: [#13](https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/kernel/branches/Kolibri-A/trunk/docs/sysfuncs.txt#L455-L468)
Sweetbread added the
Kind/Feature
Priority/Low
Status/Need More Info
 labels 2024-03-31 11:07:08 +02:00
kohsine commented 2024-03-31 19:00:35 +02:00
Author
Contributor
Copy Link

Strange, my rust-analyzer isn't warning me about unused imports. Also didn't know there was a rectangle API. Guess drawing a line would be redundant too then. Would a circle be better then? Or remove the example entirely?

Strange, my rust-analyzer isn't warning me about unused imports. Also didn't know there was a rectangle API. Guess drawing a line would be redundant too then. Would a circle be better then? Or remove the example entirely?
kohsine commented 2024-03-31 19:06:53 +02:00
Author
Contributor
Copy Link

The rectangle API can't invert colors though. My example does show the color inversion working.

The rectangle API can't invert colors though. My example does show the color inversion working.
Sweetbread commented 2024-03-31 23:15:00 +02:00
Owner
Copy Link

Strange, my rust-analyzer isn't warning me about unused imports.

изображение

The rectangle API can't invert colors though. My example does show the color inversion working.

Oh, I see. Then can you replace L42-L46 with rectangle drawing? It'll be cool

> Strange, my rust-analyzer isn't warning me about unused imports. ![изображение](/attachments/cfabbf20-b87e-486f-9f0d-951496fa7d43) > The rectangle API can't invert colors though. My example does show the color inversion working. Oh, I see. Then can you replace [L42-L46](https://git.kolibrios.org/Rust/Core/src/commit/27ea16d17128ddddc6521c4e31268f410cd51067/examples/sqr.rs#L42-L46) with rectangle drawing? It'll be cool
изображение.png
126 KiB
Sweetbread reviewed 2024-03-31 23:16:30 +02:00
src/modules/windows.rs Outdated
@@ -39,6 +39,12 @@ pub fn define_window(start: Dot, size: Size, params: WindowParams<'_>) {
}
}
pub fn put_pixel(pos: Dot, color: Option<Color>, invert: Option<bool>) {
Sweetbread commented 2024-03-31 23:16:30 +02:00
Owner
Copy Link

And invert's type better to replace with just bool, 'cuz anyway there are 2 options: None or Some(true)

And `invert`'s type better to replace with just bool, 'cuz anyway there are 2 options: `None` or `Some(true)`
Sweetbread commented 2024-03-31 23:28:29 +02:00
Owner
Copy Link

Hm, there are two another options: draw a pixel with given color or invert, so better do inversion if color is null

Hm, there are two another options: draw a pixel with given color or invert, so better do inversion if `color` is null
kohsine commented 2024-03-31 23:46:29 +02:00
Author
Contributor
Copy Link

Hm, there are two another options: draw a pixel with given color or invert, so better do inversion if color is null

Ya I like this

> Hm, there are two another options: draw a pixel with given color or invert, so better do inversion if `color` is null Ya I like this
kohsine commented 2024-03-31 23:43:46 +02:00
Author
Contributor
Copy Link

Ok let me write a better example. I admit the square example was kind of low effort. I'm thinking a wall of text and a button to invert the colors to show off a kind of basic dark mode.

Ok let me write a better example. I admit the square example was kind of low effort. I'm thinking a wall of text and a button to invert the colors to show off a kind of basic dark mode.
kohsine added 1 commit 2024-04-01 00:46:56 +02:00
dark example af1c36b894
Sweetbread changed target branch from master to feat/put_pixel 2024-04-01 12:57:34 +02:00
Sweetbread merged commit 8f52120845 into feat/put_pixel 2024-04-01 12:58:34 +02:00
Sweetbread added
Reviewed/Confirmed
 and removed
Status/Need More Info
 labels 2024-04-01 12:59:19 +02:00
Sweetbread deleted branch feature/put_pixel 2024-05-27 10:17:10 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sweetbread
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority/Critical
The priority is critical
Priority/High
The priority is high
Priority/Low
The priority is low
Priority/Medium
The priority is medium
Reviewed/Confirmed
Issue has been confirmed
Reviewed/Duplicate
This issue or pull request already exists
Reviewed/Invalid
Invalid issue
Reviewed/Won't Fix
This issue won't be fixed
Status/Abandoned
Somebody has started to work on this but abandoned work
Status/Blocked
Something is blocking this issue or pull request
Status/Need More Info
Feedback is required to reproduce issue or to continue work
Type/DLL
Type/High API
Type/Modules
No Label
Kind/Feature
Priority/Low
Reviewed/Confirmed
Milestone
No items
No Milestone
Assignees
Clear assignees
Sweetbread
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rust/Core#9
No description provided.
Delete Branch "kohsine/Core:feature/put_pixel"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?