@Burer, I've reverted that commit. But I don't think it will help with the VMWare shutdown case. Not having VMWare makes it significantly more challenging to test and debug as I kind of have to…
@Burer, does this freeze always occur on VMWare? Or does it just happen occasionally? Has this happened on previous builds?
So, since I don't have VMWare unfortunately this might get annoying for you to test. Unfortunately I'm not smart enough to know what's going on here, so if you could screenshot the output from…
@Burer Thanks. I'll check this issue out tomorrow. Seems like the controller isn't shutting down. I'm probably doing it wrong.
Update with commit c02d64b35a. System with loaded NVMe driver shuts down okay in VirtualBox, but freezes in VMWare, both when using IMG-image with driver autoload and ISO-image with manual…
@Burer, Okay I've tested this and I think it should be fixed in b0ead51d7f. Please try that. Thanks once…
@Burer: Make sure you're not using corrupted data. It's possible on some of your runs that the NVMe driver didn't finish writing some stuff and now the data is corrupted or invalid. It happened to…
Could you test this once more on Virtualbox and VMWare, with commit 19f9eb5ae6? Thanks.
YUP, that fixes it! NICE! :) (9ace6a4b52)
I've emitted the nvme-cleanup call for now though, will test…
Preserving the edi, esi registers seems to fix this issue:
push esi edi call detect_nvme test eax, eax jz .err pop edi esi
Which makes sense, since the entrypoint to…
Okay, some clue at least, so I tried moving around RegService into different places:
; No crash
invoke RegService, my_service, service_proc
ret
DEBUGF DBG_INFO, "Detecting NVMe…
Thank you for the insight. Unfortunately even when removing the nvme_cleanup call the issue still occurs. Removing the call the RegService does fix the shutdown problem, but I'm not…
@Burer, lol so this is hilarious..
Apparently the driver works without crashing when you write debug output to the screen, otherwise it doesnt. But anyways I think I've fixed the command…
If you could screenshot the screen when it freezes, that would be helpful. Thanks.
I think this is a duplicate of GSoC/kolibrios-nvme-driver#3 but I'm not sure.