KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

WIP: refactor/links #77

Closed
Sweetbread wants to merge 2 commits from (deleted):refactor/links into main
pull from: (deleted):refactor/links
merge into: KolibriOS:main
Conversation 1 Commits 2 Files Changed 6 +7 -8
Sweetbread commented 2024-06-09 23:04:01 +02:00
Owner
Copy Link

Fixes: #65, #66 and #67

Fixes: #65, #66 and #67
Sweetbread added 2 commits 2024-06-09 23:04:15 +02:00
refactor: Change link in asmxygen.py to Gitea 578eb6072c
refactor: Change links to Gitea in /programs 8669c35ee2
Sweetbread added spent time 20 minutes 2024-06-09 23:06:39 +02:00
ace-dent reviewed 2024-06-10 14:01:14 +02:00
kernel/trunk/asmxygen.py
@@ -1040,3 +1040,2 @@
if __name__ == "__main__":
link_root = "http://websvn.kolibrios.org/filedetails.php"
link_root += "?repname=Kolibri+OS&path=/kernel/trunk"
link_root = "https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/kernel/trunk"
ace-dent commented 2024-06-10 14:01:14 +02:00
Member
Copy Link

Looking good. As per my comment #65, please also change here, using the Gitea hyperlink #Lx to highlight specific line number(s).

Also we should add a comment, like: # This hardcoded link is specific to the Version Control System currently in use (Gitea). This would help any future migrations.

Looking good. As per my comment #65, please also change [here](https://github.com/KolibriOS/kolibrios/blob/f4fd3f6ea049dc4c7c0fd3b9bd41fd3377e92e0e/kernel/trunk/asmxygen.py#L401-L403), using the Gitea hyperlink `#Lx` to highlight specific line number(s). Also we should add a comment, like: `# This hardcoded link is specific to the Version Control System currently in use (Gitea)`. This would help any future migrations.
Sweetbread commented 2024-06-10 14:03:56 +02:00
Author
Owner
Copy Link

As per my comment #65, please also change here

That's why the PR is WIP

Also we should add a comment

I'm not sure. For future migrations it's possible to look into Changed files sections in this PR

> As per my comment #65, please also change here That's why the PR is WIP > Also we should add a comment I'm not sure. For future migrations it's possible to look into Changed files sections in this PR
👍 1
Sweetbread closed this pull request 2025-03-17 19:43:01 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
2 Participants
Notifications
Total Time Spent: 20 minutes
Sweetbread
20 minutes
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#77
No description provided.
Delete Branch "(deleted):refactor/links"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?