WIP: refactor/links #77

Sweetbread · 2024-06-09T23:04:01+02:00

Sweetbread commented

2024-06-09 23:04:01 +02:00

Fixes: #65, #66 and #67

Sweetbread added 2 commits 2024-06-09 23:04:15 +02:00

refactor: Change link in asmxygen.py to Gitea 578eb6072c

refactor: Change links to Gitea in /programs 8669c35ee2

Sweetbread added spent time 2024-06-09 23:06:39 +02:00

20 minutes

ace-dent reviewed 2024-06-10 14:01:14 +02:00

kernel/trunk/asmxygen.py

						
				@ -1040,3 +1040,2 @@

				if __name__ == "__main__":

				    link_root = "http://websvn.kolibrios.org/filedetails.php"

				    link_root += "?repname=Kolibri+OS&path=/kernel/trunk"

				    link_root = "https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/kernel/trunk"

ace-dent commented

2024-06-10 14:01:14 +02:00

Looking good. As per my comment #65, please also change here, using the Gitea hyperlink #Lx to highlight specific line number(s).

Also we should add a comment, like: # This hardcoded link is specific to the Version Control System currently in use (Gitea). This would help any future migrations.

Looking good. As per my comment #65, please also change [here](https://github.com/KolibriOS/kolibrios/blob/f4fd3f6ea049dc4c7c0fd3b9bd41fd3377e92e0e/kernel/trunk/asmxygen.py#L401-L403), using the Gitea hyperlink `#Lx` to highlight specific line number(s). Also we should add a comment, like: `# This hardcoded link is specific to the Version Control System currently in use (Gitea)`. This would help any future migrations.

Sweetbread commented

2024-06-10 14:03:56 +02:00

As per my comment #65, please also change here

That's why the PR is WIP

Also we should add a comment

I'm not sure. For future migrations it's possible to look into Changed files sections in this PR

> As per my comment #65, please also change here That's why the PR is WIP > Also we should add a comment I'm not sure. For future migrations it's possible to look into Changed files sections in this PR

👍 1

This pull request is marked as a work in progress.

This branch is out-of-date with the base branch

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u refactor/links:Sweetbread-refactor/links

git checkout Sweetbread-refactor/links

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Total Time Spent: 20 minutes

Sweetbread

20 minutes

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#77