KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

Fix docpack shortcut for sysfuncs in text editors #222

Merged
mxlgv merged 1 commits from dunkaist/kolibrios:dunkaist-pr-fix-docpack-sysfuncs-tinypad-cedit into main 2025-04-30 11:44:54 +02:00
Conversation 10 Commits 1 Files Changed 3 +3 -3
dunkaist commented 2025-04-28 23:06:45 +02:00
Owner
Copy Link

Docpack app has several help files included. Tinypad and CEdit run the
app to show one of sysfuncs.txt/sysfuncr.txt files. The text editors
pass a one-letter argument to specify the text file. It used to be 'f'
for sysfuncs, it has become 'e' recently. Update this one-letter
argument both in tinypad and cedit.

Resolve #216

Docpack app has several help files included. Tinypad and CEdit run the app to show one of sysfuncs.txt/sysfuncr.txt files. The text editors pass a one-letter argument to specify the text file. It used to be 'f' for sysfuncs, it has become 'e' recently. Update this one-letter argument both in tinypad and cedit. Resolve #216
dunkaist added 1 commit 2025-04-28 23:06:48 +02:00
Fix docpack shortcut for sysfuncs in text editors
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 51s
Details
Build system / Build (pull_request) Successful in 6m42s
Details
9980ea63f8 
Docpack app has several help files included. Tinypad and CEdit run the
app to show one of sysfuncs.txt/sysfuncr.txt files. The text editors
pass a one-letter argument to specify the text file. It used to be 'f'
for sysfuncs, it has become 'e' recently. Update this one-letter
argument both in tinypad and cedit.

Resolve #216
ace-dent commented 2025-04-29 12:01:30 +02:00
Member
Copy Link

@dunkaist - do you know why the letter was changed?

Ok - found the change in 78d5942bb8 (diff-1f661e1877b22e5291172300868fd94f7e408168)

Are any of the other re-labelled docs linked to elsewhere?

<s>@dunkaist - do you know why the letter was changed? </s> Ok - found the change in https://git.kolibrios.org/KolibriOS/kolibrios/commit/78d5942bb847f3eced42ec8f2e00a259e71cef23#diff-1f661e1877b22e5291172300868fd94f7e408168 Are any of the other re-labelled docs linked to elsewhere?
dunkaist commented 2025-04-29 19:49:17 +02:00
Author
Owner
Copy Link

Are any of the other re-labelled docs linked to elsewhere?

You never know for sure, but quick grep'ping didn't reveal similar issues.

> Are any of the other re-labelled docs linked to elsewhere? You never know for sure, but quick grep'ping didn't reveal similar issues.
👍 1
ace-dent requested review from ace-dent 2025-04-30 00:35:36 +02:00
ace-dent approved these changes 2025-04-30 00:36:04 +02:00
Dismissed
mxlgv commented 2025-04-30 02:19:19 +02:00
Owner
Copy Link

@dunkaist Did I understand correctly that the letter here is an index in docpack?

@dunkaist Did I understand correctly that the letter here is an index in docpack?
mxlgv added the
PR
Review required
 label 2025-04-30 02:19:44 +02:00
mxlgv requested review from mxlgv 2025-04-30 02:19:58 +02:00
dunkaist commented 2025-04-30 02:23:44 +02:00
Author
Owner
Copy Link

@dunkaist Did I understand correctly that the letter here is an index in docpack?

Yes

> @dunkaist Did I understand correctly that the letter here is an index in docpack? Yes
mxlgv commented 2025-04-30 02:30:15 +02:00
Owner
Copy Link

@dunkaist - do you know why the letter was changed?

Ok - found the change in 78d5942bb8 (diff-1f661e1877b22e5291172300868fd94f7e408168)

Are any of the other re-labelled docs linked to elsewhere?

Very dirty patch... I hope I never see anything like this again.

> <s>@dunkaist - do you know why the letter was changed? </s> > > Ok - found the change in https://git.kolibrios.org/KolibriOS/kolibrios/commit/78d5942bb847f3eced42ec8f2e00a259e71cef23#diff-1f661e1877b22e5291172300868fd94f7e408168 > > Are any of the other re-labelled docs linked to elsewhere? Very dirty patch... I hope I never see anything like this again.
mxlgv approved these changes 2025-04-30 02:33:19 +02:00
Dismissed
mxlgv requested changes 2025-04-30 02:50:50 +02:00
Dismissed
mxlgv left a comment
Owner
Copy Link

@dunkaist It seems there is a date in the Cedit header. Should it be changed after your changes?

@dunkaist It seems there is a date in the Cedit header. Should it be changed after your changes?
mxlgv added
PR
Request changes
 and removed
PR
Review required
 labels 2025-04-30 02:50:57 +02:00
dunkaist force-pushed dunkaist-pr-fix-docpack-sysfuncs-tinypad-cedit from 9980ea63f8 to cd1c2ce969 2025-04-30 02:51:29 +02:00 Compare
dunkaist dismissed ace-dent’s review 2025-04-30 02:51:30 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dunkaist commented 2025-04-30 02:52:19 +02:00
Author
Owner
Copy Link

@dunkaist It seems there is a date in the Cedit header. Should it be changed after your changes?

Perhaps yes, done.

> @dunkaist It seems there is a date in the Cedit header. Should it be changed after your changes? Perhaps yes, done.
mxlgv approved these changes 2025-04-30 03:11:06 +02:00
mxlgv scheduled this pull request to auto merge when all checks succeed 2025-04-30 03:11:20 +02:00
mxlgv merged commit cd1c2ce969 into main 2025-04-30 11:44:54 +02:00
mxlgv added
PR
Ready to merge
 and removed
PR
Request changes
 labels 2025-04-30 11:45:05 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
PR
Ready to merge
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#222
No description provided.
Delete Branch "dunkaist/kolibrios:dunkaist-pr-fix-docpack-sysfuncs-tinypad-cedit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?